From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32543 invoked by alias); 6 Oct 2009 14:46:47 -0000 Received: (qmail 32535 invoked by uid 22791); 6 Oct 2009 14:46:46 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Oct 2009 14:46:41 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.2/jtpda-5.5pre1) with ESMTP id n96EhvLw013489 ; Tue, 6 Oct 2009 16:43:57 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id n96Ehu9Z028043 ; Tue, 6 Oct 2009 16:43:56 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id n96EhuMu065444 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Tue, 6 Oct 2009 16:43:56 +0200 (CEST) (envelope-from muller@ics.u-strasbg.fr) From: "Pierre Muller" To: "'Joel Brobecker'" Cc: References: <00a301ca4368$63c22c90$2b4685b0$@u-strasbg.fr> <20091002232011.GH10338@adacore.com> In-Reply-To: <20091002232011.GH10338@adacore.com> Subject: [RFA] Testsuite: Remove obsolete match_max uses Date: Tue, 06 Oct 2009 14:46:00 -0000 Message-ID: <000001ca4693$7a8e1870$6faa4950$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00128.txt.bz2 I've checked in the patch. > > PS1: If this is approved, we should also > > consider what to do about the three tests > > that set another value of match_max > > (lower than the 30000). > > We should simply remove them, since this is now handled automatically. This new RFA handles this removal: Tested manually on cygwin and ubuntu/i386 without any changes in modified tests results. 2009-10-05 Pierre Muller * gdb.base/annota1.exp: Remove obsolete match_max increase. * gdb.base/annota3.exp: Idem. * gdb.base/maint.exp: Idem. Index: src/gdb/testsuite/gdb.base/annota1.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v retrieving revision 1.34 diff -u -F^proc -r1.34 annota1.exp --- src/gdb/testsuite/gdb.base/annota1.exp 13 Jul 2009 19:20:39 -0000 1.34 +++ src/gdb/testsuite/gdb.base/annota1.exp 5 Oct 2009 06:30:43 -0000 @@ -297,12 +297,6 @@ # test: # annotate-signal-handler-caller # - verbose "match_max local is: [match_max]" - verbose "match_max default is: [match_max -d]" - # This is necessary because a 2000 buffer is not enought to get everything - # up to the prompt ad the test gets a timeout. - match_max 3000 - verbose "match_max now is: [match_max]" send_gdb "backtrace\n" gdb_expect { -re "frame-begin 0 $hex\r\n#0.*frame-end.*frame-begin 1 $hex\r\n#1.*(\032\032signal-handler-caller\r\n.signal handler called.\r\n\r\n)+\032\032frame-end\r\n\r\n\032\032frame-begin 2 $hex\r\n#2.*(frame-begin 3 $hex\r\n#3.*)*frame-end.*$gdb_prompt$" { Index: src/gdb/testsuite/gdb.base/annota3.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v retrieving revision 1.19 diff -u -F^proc -r1.19 annota3.exp --- src/gdb/testsuite/gdb.base/annota3.exp 3 Jan 2009 05:58:03 -0000 1.19 +++ src/gdb/testsuite/gdb.base/annota3.exp 5 Oct 2009 06:30:43 -0000 @@ -258,12 +258,6 @@ # # test: # - verbose "match_max local is: [match_max]" - verbose "match_max default is: [match_max -d]" - # This is necessary because a 2000 buffer is not enought to get everything - # up to the prompt ad the test gets a timeout. - match_max 3000 - verbose "match_max now is: [match_max]" send_gdb "backtrace\n" gdb_expect_list "backtrace @ signal handler" "$gdb_prompt$" { "#0 +handle_USR1 \[^\r\n\]+\r\n" Index: src/gdb/testsuite/gdb.base/maint.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v retrieving revision 1.37 diff -u -F^proc -r1.37 maint.exp --- src/gdb/testsuite/gdb.base/maint.exp 3 Jan 2009 05:58:03 -0000 1.37 +++ src/gdb/testsuite/gdb.base/maint.exp 5 Oct 2009 06:30:44 -0000 @@ -96,8 +96,6 @@ send_gdb "set height 0\n" gdb_expect -re "$gdb_prompt $" -# use a larger expect input buffer for long help outputs. -match_max 6000 # # this command does not produce any output