From mboxrd@z Thu Jan 1 00:00:00 1970 From: tglx@linutronix.de (Thomas Gleixner) Date: Tue, 24 Mar 2009 20:14:06 +0100 (CET) Subject: [ltt-dev] [patch 6/9] LTTng instrumentation - timer In-Reply-To: <20090324182122.GG31117@elte.hu> References: <20090324155625.420966314@polymtl.ca> <20090324160148.754766083@polymtl.ca> <20090324182122.GG31117@elte.hu> Message-ID: On Tue, 24 Mar 2009, Ingo Molnar wrote: > the init methods are missing from your patch entirely - and the rest > is partially incomplete as well. > > Instrumentation of the del_timer() variants is missing. For a > complete lifetime analysis of timers this cannot be left out. Look at the debugobjects hooks. They cover the complete timer life time already. Piggypacking tracepoints on those would simplify maintenance and reduce the number of extra lines in the code. Thanks, tglx