Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
Subject: [ltt-dev] [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc symbols v2
Date: Tue, 17 Mar 2009 09:29:35 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.0903170919310.29264@localhost.localdomain> (raw)
In-Reply-To: <20090317000859.GB19848@Krystal>

On Mon, 16 Mar 2009, Mathieu Desnoyers wrote:

> * Thomas Gleixner (tglx at linutronix.de) wrote:
> > Is this a contribution to the "most useless patch of the week"
> > contest ?
> > 
> > You have my vote.
> > 
> 
> Count mine too ! :) Actually, this was not what it should look like.
> Here is my version. I am not totally convinced that the struct irq_desc
> is absolutely required, but in some include orders, it might matter.

I have not seen a compile failure report yet.

> However, the #endif around the EXPORT_SYMBOL is definitely needed.

Right.

>  	struct irq_desc *desc = irq_to_desc(irq);
>  	return desc ? desc->kstat_irqs[cpu] : 0;
>  }
> -#endif
>  EXPORT_SYMBOL(kstat_irqs_cpu);
> +#endif

Thanks,

	tglx



  parent reply	other threads:[~2009-03-17  8:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16 18:22 [ltt-dev] 2.6.29-rc7-lttng-0.110 broken with CONFIG_SLUB Josh Boyer
2009-03-16 19:44 ` Mathieu Desnoyers
2009-03-16 20:01   ` Josh Boyer
2009-03-16 20:25     ` Mathieu Desnoyers
2009-03-16 20:58       ` Josh Boyer
2009-03-16 21:53         ` Mathieu Desnoyers
2009-03-16 22:05           ` Josh Boyer
2009-03-16 23:11             ` [ltt-dev] [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc symbols Mathieu Desnoyers
2009-03-16 23:52               ` Thomas Gleixner
2009-03-17  0:08                 ` [ltt-dev] [PATCH] kernel/irq/handle.c fix kstat_irqs_cpu and irq_to_desc symbols v2 Mathieu Desnoyers
2009-03-17  0:34                   ` Josh Boyer
2009-03-17  8:29                   ` Thomas Gleixner [this message]
2009-03-16 20:47     ` [ltt-dev] 2.6.29-rc7-lttng-0.110 broken with CONFIG_SLUB Mathieu Desnoyers
2009-03-16 21:01       ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0903170919310.29264@localhost.localdomain \
    --to=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox