From: nils.carlson@ericsson.com (Nils Carlson)
Subject: [ltt-dev] [PATCH UST] Fix insecure library loading (Debian Bug #598309, CVE-2010-3386)
Date: Thu, 30 Sep 2010 12:18:52 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1009301029160.18303@as68123.uab.ericsson.se> (raw)
In-Reply-To: <20100929150622.GA6625@Krystal>
Comments below.
On Wed, 29 Sep 2010, Mathieu Desnoyers wrote:
> Thanks to Raphael Geissert for spotting this, and to Jon Bernard for forwarding
> the information to us.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> CC: Raphael Geissert <geissert at debian.org>
> CC: Jon Bernard <jbernard at debian.org>
> ---
> usttrace | 47 +++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 37 insertions(+), 10 deletions(-)
>
> Index: ust/usttrace
> ===================================================================
> --- ust.orig/usttrace
> +++ ust/usttrace
> @@ -132,27 +132,54 @@ fi
>
> if [ "$arg_preload_libust" = "1" ];
> then
> - if [ -n "${LIBUST_PATH%libust.so}" ] ; then
> - export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${LIBUST_PATH%libust.so}"
> + if [ -n "${LIBUST_PATH%libust.so}" ];
> + then
> + if [ -n "$LD_LIBRARY_PATH" ];
> + then
> + export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${LIBUST_PATH%libust.so}"
> + else
> + export LD_LIBRARY_PATH="${LIBUST_PATH%libust.so}"
> + fi
> + fi
> + if [ -n "$LIBUST_PATH" ];
> + then
> + if [ -n "$LD_PRELOAD" ];
> + then
> + export LD_PRELOAD="$LD_PRELOAD:$LIBUST_PATH"
> + else
> + export LD_PRELOAD="$LIBUST_PATH"
> + fi
> fi
> - export LD_PRELOAD="$LD_PRELOAD:$LIBUST_PATH"
> fi
>
> - if [ "$arg_ld_std_ust" = "1" ];
> + if [ "$arg_ld_std_ust" = "1" ] && [ -n "${LIBUST_PATH%libust.so}" ];
> then
> - if [ -n "$${LIBUST_PATH%libust.so}" ] ; then
> - export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${LIBUST_PATH%libust.so}"
> + if [ -n "$LD_LIBRARY_PATH" ];
> + then
> + export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:${LIBUST_PATH%libust.so}"
> + else
> + export LD_LIBRARY_PATH="${LIBUST_PATH%libust.so}"
> fi
> fi
>
> - if [ "$arg_preload_malloc" = "1" ];
> + if [ "$arg_preload_malloc" = "1" ] && [ -n $LIBMALLOCWRAP_PATH ];
All -n tests have to be in "", otherwise they will pass even though the
string is empty.
> then
> - export LD_PRELOAD="$LD_PRELOAD:$LIBMALLOCWRAP_PATH"
> + if [ -n "$LD_PRELOAD" ];
> + then
> + export LD_PRELOAD="$LD_PRELOAD:$LIBMALLOCWRAP_PATH"
> + else
> + export LD_PRELOAD="$LIBMALLOCWRAP_PATH"
> + fi
> fi
>
> - if [ "$arg_preload_fork" = "1" ];
> + if [ "$arg_preload_fork" = "1" ] && [ -n $LIBINTERFORK_PATH ];
Same here.
> then
> - export LD_PRELOAD="$LD_PRELOAD:$LIBINTERFORK_PATH"
> + if [ -n "$LD_PRELOAD" ];
> + then
> + export LD_PRELOAD="$LD_PRELOAD:$LIBINTERFORK_PATH"
> + else
> + export LD_PRELOAD="$LIBINTERFORK_PATH"
> + fi
> fi
>
Looks good otherwise!
/Nils
> # Execute the command
>
> --
> Mathieu Desnoyers
> Operating System Efficiency R&D Consultant
> EfficiOS Inc.
> http://www.efficios.com
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>
next prev parent reply other threads:[~2010-09-30 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 13:27 [ltt-dev] [geissert@debian.org: Bug#598309: ust-bin: CVE-2010-3386: insecure library loading] Jon Bernard
2010-09-29 13:32 ` David Goulet
2010-09-29 13:47 ` Mathieu Desnoyers
2010-09-29 15:16 ` Alexandre Montplaisir
2010-09-29 15:47 ` Mathieu Desnoyers
2010-09-29 15:06 ` [ltt-dev] [PATCH UST] Fix insecure library loading (Debian Bug #598309, CVE-2010-3386) Mathieu Desnoyers
2010-09-29 16:32 ` David Goulet
2010-09-29 17:25 ` Mathieu Desnoyers
2010-09-29 18:57 ` Nils Carlson
2010-09-29 20:40 ` [ltt-dev] [UST] malloc error found by david Mathieu Desnoyers
2010-09-29 23:01 ` David Goulet
2010-09-30 19:21 ` Nils Carlson
2010-09-29 23:11 ` [ltt-dev] [PATCH UST] Fix insecure library loading (Debian Bug #598309, CVE-2010-3386) David Goulet
2010-09-30 10:18 ` Nils Carlson [this message]
2010-09-30 14:49 ` [ltt-dev] [PATCH UST] Fix insecure library loading (Debian Bug #598309, CVE-2010-3386) (v2) Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1009301029160.18303@as68123.uab.ericsson.se \
--to=nils.carlson@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox