Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: nils.carlson@ericsson.com (Nils Carlson)
Subject: [ltt-dev] UST socket protocol
Date: Thu, 9 Sep 2010 17:45:32 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1009091742310.12865@as68123.uab.ericsson.se> (raw)
In-Reply-To: <4C888C58.9090608@polymtl.ca>



On Thu, 9 Sep 2010, Pierre-Marc Fournier wrote:

> On 09/07/2010 02:30 AM, Nils Carlson wrote:
>> I've been looking through the socket protocol for UST and am a bit
>> curious about the construction of it. Is there a reason we haven't just
>> defined a ustctl package type with a command field, a result field and a
>> data field?
>>
>
> Not sure I understand.
>
> There is the socket protocol and there is the ustcmd API. The ustcmd API
> is there to make it easy to control tracing in a system from within a C
> program like TCF or ustctl. It in turn converts the commands it receives
> to the text-based ust socket protocol which libust (inside the traced
> app) is able to parse.

That's the one I'm reffering to. And what I'm asking is why it's using 
plain text to do option parsing and not some much simpler binary commands? 
As all the parts are part of libust and no traffic is going over a network 
you could more or less send whole structs and use enums for commands, this 
would reduce the amount of parsing code substantially.

/Nils



      reply	other threads:[~2010-09-09 15:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07  6:30 Nils Carlson
2010-09-07 13:24 ` Michel Dagenais
2010-09-09  7:27 ` Pierre-Marc Fournier
2010-09-09 15:45   ` Nils Carlson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1009091742310.12865@as68123.uab.ericsson.se \
    --to=nils.carlson@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox