From mboxrd@z Thu Jan 1 00:00:00 1970 From: simon.marchi@polymtl.ca (Simon Marchi) Date: Thu, 28 Apr 2016 14:36:17 -0400 Subject: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST In-Reply-To: <808373029.72582.1461868129007.JavaMail.zimbra@efficios.com> References: <1461811940-8336-1-git-send-email-simon.marchi@polymtl.ca> <1804225761.72412.1461860179512.JavaMail.zimbra@efficios.com> <1d03bf34bd523c31ab8d32e7abda56ec@simark.ca> <808373029.72582.1461868129007.JavaMail.zimbra@efficios.com> Message-ID: On 2016-04-28 14:28, Michael Jeanson wrote: > ----- On Apr 28, 2016, at 12:44 PM, Simon Marchi > simon.marchi at polymtl.ca wrote: >> >> Ok thanks. >> >> Just an idea: I find it quite cumbersome to add a new entry in >> configure.ac for each test script that we want autoconf to process >> (such >> as in patch 3/3). I think it could be easier to have a single file >> (e.g. vars.sh) and have it contain definitions of various directories: >> >> srcdir=@srcdir@ >> top_srcdir=@top_srcdir@ >> abs_top_srcdir=@abs_top_srcdir@ >> builddir=@builddir@ >> ... >> >> This way, you could have only a single generated file (vars.sh.in -> >> vars.sh), and each test script would just have to source that file to >> use the values. > > As discussed on #lttng, here is the PR resulting from my updates to > your > patches : > > https://github.com/efficios/babeltrace/pull/43 Thanks for following up. > Concerning the include file, I'm not convinced it would be simpler, we > would > end up with static scripts in the source dir including a generated file > in > the builddir. In the current state, even the static scripts are copied to the build dir, so it wouldn't be a problem. Anyway, if it's not a problem, I think it looks good in your PR.