From: "Ondřej Surý via lttng-dev" <lttng-dev@lists.lttng.org>
To: lttng-dev <lttng-dev@lists.lttng.org>
Subject: [lttng-dev] TSAN build broken on master branch
Date: Thu, 21 Sep 2023 20:34:48 +0200 [thread overview]
Message-ID: <FA4E40F7-C16C-4872-9829-0643AA974B30@sury.org> (raw)
Hi,
I've updated to the latest HEAD and compilation with clang-16 and clang-17 and
./configure --enable-compiler-atomic-builtins --disable-legacy-mb
It fails with:
rculfhash.c:1189:2: error: address argument to atomic operation must be a pointer to integer ('typeof (node_next)' (aka 'struct cds_lfht_node **') invalid)
uatomic_or_mo(node_next, REMOVED_FLAG, CMM_RELEASE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/urcu/uatomic/builtins-generic.h:123:10: note: expanded from macro 'uatomic_or_mo'
(void) __atomic_or_fetch(cmm_cast_volatile(addr), mask, \
^ ~~~~~~~~~~~~~~~~~~~~~~~
rculfhash.c:1440:3: error: address argument to atomic operation must be a pointer to integer ('typeof (fini_bucket_next)' (aka 'struct cds_lfht_node **') invalid)
uatomic_or(fini_bucket_next, REMOVED_FLAG);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/urcu/uatomic/builtins-generic.h:130:2: note: expanded from macro 'uatomic_or'
uatomic_or_mo(addr, mask, CMM_RELAXED)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../include/urcu/uatomic/builtins-generic.h:123:10: note: expanded from macro 'uatomic_or_mo'
(void) __atomic_or_fetch(cmm_cast_volatile(addr), mask, \
^ ~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
It works with gcc-12, so it seems that clang has stricter rules here.
Ondřej
--
Ondřej Surý (He/Him)
ondrej@sury.org
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next reply other threads:[~2023-09-21 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:34 Ondřej Surý via lttng-dev [this message]
2023-09-21 20:21 ` Olivier Dion via lttng-dev
2023-09-23 6:03 ` Mathieu Desnoyers via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA4E40F7-C16C-4872-9829-0643AA974B30@sury.org \
--to=lttng-dev@lists.lttng.org \
--cc=ondrej@sury.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox