Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: hannes.weisbach@mailbox.tu-dresden.de (Hannes Weisbach)
Subject: [lttng-dev] [BUG] lttng-sessiond
Date: Fri, 24 Apr 2015 11:52:07 +0200	[thread overview]
Message-ID: <DE838679-50E7-464E-B47B-934EF31813A9@mailbox.tu-dresden.de> (raw)
In-Reply-To: <1795330554.35257.1429820009277.JavaMail.zimbra@efficios.com>

Hello,

>> Can you share with us the code of your "hello" probe ?
I used the example code from
http://lttng.org/docs/#doc-instrumenting-linux-kernel-itself .

>> Which version or git commit of lttng-modules are you
>> using ?
I used the current master of the github mirrors, specifically:
lttng-tools: 94ffb05d6777efc0c40394d3df44a04feed92953
lttng-modules: d0558de29ca516e83b388b8028651f8b69288e4e
lttng-ust: 4bc1ccd721114691c6f0dbd65335b3c43c9f895f

> I think the two issues should be fixed by this new
> git commit in lttng-modules master branch:
> 
> commit 66fd8d5e4a6080f1b2db0f525c26c07e5b723aab
> Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> Date:   Thu Apr 23 16:11:15 2015 -0400
> 
>    Fix: double-unlock of session mutex
> 
>    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> 
> Can you give it a try ?
Yes, the mutex error goes away.  However, loading multiple probes with
either --kmod-probes or --extra-kmod-probes still does not work:
$ sudo lttng-sessiond -vvv --extra-kmod-probes=sched,napi
[...]
DEBUG1 - 11:42:18.492870 [5358/5358]: Modprobe successfully lttng-probe-napi (in modprobe_lttng() at modprobe.c:285)
sh: 1: Syntax error: "(" unexpected
DEBUG1 - 11:42:18.495037 [5358/5358]: Unable to load optional module (null); continuing (in modprobe_lttng() at modprobe.c:281)
[...]

Also, lttng-probe-regmap does not compile, but that might have to do
with my kernel version of 4.0.0-rc4 (commit
b314acaccd7e0d55314d96be4a33b5f50d0b3344 from
https://github.com/torvalds/linux):

lttng-modules$ make KERNELDIR=/usr/src/linux-4.0.0-rc4-atlas+
make -C /usr/src/linux-4.0.0-rc4-atlas+ M=/home/hannesweisbach/atlas/lttng-modules modules
make[1]: Entering directory '/usr/src/linux-4.0.0-rc4-atlas+'
  CC [M]  /home/hannesweisbach/atlas/lttng-modules/probes/lttng-probe-regmap.o
In file included from /home/hannesweisbach/atlas/lttng-modules/probes/../instrumentation/events/lttng-module/../../../probes/define_trace.h:100:0,
                 from /home/hannesweisbach/atlas/lttng-modules/probes/../instrumentation/events/lttng-module/regmap.h:278,
                 from /home/hannesweisbach/atlas/lttng-modules/probes/lttng-probe-regmap.c:41:
/home/hannesweisbach/atlas/lttng-modules/probes/../instrumentation/events/lttng-module/../../../probes/lttng-events.h:134:6: error: conflicting types for ?trace_regmap_reg_write?
 void trace_##_name(_proto);
      ^
/home/hannesweisbach/atlas/lttng-modules/probes/../instrumentation/events/lttng-module/../../../probes/lttng-events.h:99:2: note: in expansion of macro ?LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP?
  LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(template, name, name, PARAMS(proto), PARAMS(args))
  ^
/home/hannesweisbach/atlas/lttng-modules/probes/../instrumentation/events/lttng-module/../../../probes/../instrumentation/events/lttng-module/regmap.h:34:1: note: in expansion of macro ?LTTNG_TRACEPOINT_EVENT_INSTANCE?
 LTTNG_TRACEPOINT_EVENT_INSTANCE(regmap_reg, regmap_reg_write,
 ^
In file included from include/trace/events/regmap.h:8:0,
                 from /home/hannesweisbach/atlas/lttng-modules/probes/lttng-probe-regmap.c:32:
include/linux/tracepoint.h:169:21: note: previous definition of ?trace_regmap_reg_write? was here
  static inline void trace_##name(proto)    \
                     ^
include/linux/tracepoint.h:325:3: note: in expansion of macro ?__DECLARE_TRACE?
   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), 1, \
   ^
include/linux/tracepoint.h:448:2: note: in expansion of macro ?DECLARE_TRACE?
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^
include/trace/events/regmap.h:40:1: note: in expansion of macro ?DEFINE_EVENT?
 DEFINE_EVENT(regmap_reg, regmap_reg_write,
 ^

[ and so on, and so on ? ]

Since I don't need the regmap probe I simply disabled it in
probes/Makefile.  Unfortunately, I don't have time to debug it myself.
If you want me to try another version, let me know.

Best regards,
Hannes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20150424/81859d2d/attachment.sig>


  reply	other threads:[~2015-04-24  9:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 10:04 Hannes Weisbach
2015-04-23 19:26 ` Mathieu Desnoyers
2015-04-23 20:13   ` Mathieu Desnoyers
2015-04-24  9:52     ` Hannes Weisbach [this message]
2015-04-24 18:32       ` Mathieu Desnoyers
2015-04-25 14:13         ` Hannes Weisbach
2015-04-25 14:37         ` Hannes Weisbach
2015-04-25 15:37           ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE838679-50E7-464E-B47B-934EF31813A9@mailbox.tu-dresden.de \
    --to=hannes.weisbach@mailbox.tu-dresden.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox