From mboxrd@z Thu Jan  1 00:00:00 1970
From: llozano@google.com (Luis Lozano)
Date: Thu, 21 Nov 2013 15:45:35 -0800
Subject: [lttng-dev] current_thread_info() not respecting program order
	with gcc 4.8.x
In-Reply-To: <528E94E2.3080102@ahsoftware.de>
References: <52803E5D.3050109@mentor.com> <52851395.3010306@mentor.com>
	<67652521.68027.1384482849638.JavaMail.zimbra@efficios.com>
	<1691607547.70809.1384874952002.JavaMail.zimbra@efficios.com>
	<CA+55aFw923sA0E1RQNxFF0OWFtAfcaG-dBUc-0YYZGDSAsaQyg@mail.gmail.com>
	<528E2E8E.8080004@ahsoftware.de>
	<CA+55aFyNZun07BLoD2KQFT7cN1xsiQ2gE6hYwRvOGa3tCap4CQ@mail.gmail.com>
	<528E94E2.3080102@ahsoftware.de>
Message-ID: <CANxoKds1iLpXK0yb1qW_Z4tLSRccrf69nYUV7mLSJBMwSrjwmQ@mail.gmail.com>

I think we need a reproducer. Without this we may all be going on the
wrong path. This whole conversation started on an *assumption* that
some accesses were being reordered.

evidence of the reorder or reproducer please?

Luis


On Thu, Nov 21, 2013 at 3:18 PM, Alexander Holler <holler at ahsoftware.de> wrote:
>
> Am 21.11.2013 23:32, schrieb Linus Torvalds:
>
>> On Thu, Nov 21, 2013 at 8:02 AM, Alexander Holler <holler at ahsoftware.de>
>> wrote:
>
>
>> The bug is not that gcc can re-order or combine the accesses to "sp".
>> WE WANT THAT TO HAPPEN.
>
>
> Sure, and I don't disagree on that.
>
>
>>
>> The bug is *outside* that "current_thread_info()" macro/inline
>> function. It's the *dereference* of the pointer that gcc re-orders.
>> AND THAT IS WRONG.
>>
>> Gcc seems to mess up the alias analysis, and decide that the
>> deferences cannot alias. Which is wrong. They clearly *can* alias,
>> exactly because the value of "sp & ~(THREAD_SIZE - 1)" ends up having
>> the same value all the time.
>
>
> Sorry, that I still disagree.
>
> I try to describe it more clearly why I still think that the problem might
> be because of that const declaration.
>
> (...)
>
> foobar1 = current_thread_info() __attribute_const__ {
>         return sp->somewhere_local;
> }
>
> (...)
>
> foobar2 = current_thread_info() __attribute_const__ {
>         return sp->somewhere_local;
> }
>
> So, even if sp is the same in both cases, that const states that wherever sp
> points to is local to current_thread_info(), so it can't be the same for
> both cases.
>
> Regards,
>
> Alexander Holler



-- 

Luis A. Lozano | Software Engineer | llozano at google.com | +1 (408)431-5164