From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uI6OH3Yv+GITdiYAWB0awg (envelope-from ) for ; Sat, 13 Aug 2022 19:10:46 -0400 Received: by simark.ca (Postfix, from userid 112) id 73D561E5EA; Sat, 13 Aug 2022 19:10:46 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=lists.lttng.org header.i=@lists.lttng.org header.a=rsa-sha256 header.s=default header.b=MRc6ZWYp; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.lttng.org (lists.lttng.org [167.114.26.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCCC61E222 for ; Sat, 13 Aug 2022 19:10:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.lttng.org; s=default; t=1660432245; bh=yAbPkGu0Af95dfaYpeZygr1TgeQqgPaXFtYZUVEnfqc=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=MRc6ZWYpTZ6uTl/SYuNXtbRWK4nWAS8F8SLsc2FUa6n1eVh3KzHxM5H5hPahJDDFX 67/PZ/iKfpXSznOcCirGYW12ZQN41sVD7Xm0oXUOFISVnWE6UKSlxRCD7caQxC9IUv rwxd8QTz3ogkQedjisgqY4LqqyHJGzpr20ncNoRrxIrH9Wl/oYbfewOX3UbHlPucZd v1pn5RxlxmRIVdW2n+Jo1U1aKyCHD5E333Sngky2QqCfZAfTLf8T73N3V+7/YPhZay Wu5MWiOI/at8F70Fd7nAf00zOlRQttFdf767NE1dlayV2n5fKxsT/gzTEXobUBKyx2 oXqSs2apUqaGQ== Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4M4x9K1Ghmz1FmQ; Sat, 13 Aug 2022 19:10:45 -0400 (EDT) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lists.lttng.org (Postfix) with ESMTPS id 4M4x9J0SZdz1G0c for ; Sat, 13 Aug 2022 19:10:43 -0400 (EDT) Received: by mail-ej1-x630.google.com with SMTP id y13so7663214ejp.13 for ; Sat, 13 Aug 2022 16:10:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=RdI6qVHlv9RVbsiDPMK86MwzbNb3rhB9uP0gti6S580=; b=UPQ5nSTEYgN1kMtsR3pULzT16uAVQ8KzJFMcu4ugEmy9jINPDgMT/kR0Q+ysQrOiJc AW0MNRMacm/0AvbYkhGHF5ZuW/cUB9gBIyXsxQs0tRpm9upE1cbcAcdG3It8jAhb4Thw jy4MUclOqXKYg4qYZFjnbWGG+4p+EoHY7VYzDcQO3ZaVIvyNBgfBP9r6BbZlu1+gpToy jzc70HxMUg8NEalT8dtpwcp7b2KR36iD6xqld/APv4ytYLRiuXr6w4NTypGNM5vTY8Ik fwT/NfE6lsZwuS4qJ8Bw2CplZB7B8/djek5OkmskbHVuEUckmj6CgS4IsIMBIOPdoESr kBOg== X-Gm-Message-State: ACgBeo1sJJnzzmt0kBp3nS6NwlPNmuEUfMntnn2BAD+n/HyXpqcj79mi /v6+8R430r8cWq1+/GtR3nv7zH/kcV84uK5qX0zRvO55USNlKA== X-Google-Smtp-Source: AA6agR4qQ13SmmtTXo9dpGannkS1UoNscxY21+2yM6NFmPMaN6Q+sb+80oKKhPSLrW1wzyKlgjMaKUTdTqpzTZJnt8E= X-Received: by 2002:a17:906:93ef:b0:731:1478:b774 with SMTP id yl15-20020a17090693ef00b007311478b774mr6153372ejb.531.1660432242058; Sat, 13 Aug 2022 16:10:42 -0700 (PDT) MIME-Version: 1.0 Date: Sat, 13 Aug 2022 19:10:30 -0400 Message-ID: To: lttng-dev@lists.lttng.org Subject: [lttng-dev] Change to CPU number detection breaks QNX compilation X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Elad Lahav via lttng-dev Reply-To: Elad Lahav Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" Hello, I have just downloaded and built the library for QNX/aarch64 and noticed that the code in compat-smp.h breaks the build. This file appears to be a (very) recent addition, from this commit: --- commit 5cfe81b7ddff9543d451746de9965cac58c67182 Author: Michael Jeanson Date: Wed Jul 27 10:44:00 2022 -0400 fix: sysconf(_SC_NPROCESSORS_CONF) can be less than max cpu id --- I started working around it, but it got a bit ugly. Is the change not a Linuxism? Does it make sense on other systems? If QNX is the exception then I can try to come up with a patch, but if not perhaps the entire code should be wrapped by #ifdef __linux__? --Elad _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev