Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: raphael.beamonte@gmail.com (Raphaël Beamonte)
Subject: [lttng-dev] [lttng-tools PATCH] checkpatch: change status of warning from "BRACES" to "BRACES_SINGLE_STMT"
Date: Wed, 13 Nov 2013 00:47:01 -0500	[thread overview]
Message-ID: <CAE_Gge2gApvf-+RmhPeDuD3vEvu4LM6R1OfxGvVPc1Ns3aD6PQ@mail.gmail.com> (raw)

Forgot to add "lttng-tools" in the subject prefix, sorry.


2013/11/13 Rapha?l Beamonte <raphael.beamonte at gmail.com>
>
> The warning about braces that are not necessary for any arm of a statement
> should be interpreted as a warning about braces around single statements.
>
> Signed-off-by: Rapha?l Beamonte <raphael.beamonte at gmail.com>
> ---
>  extras/checkpatch.pl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/extras/checkpatch.pl b/extras/checkpatch.pl
> index fdd8484..5a67704 100755
> --- a/extras/checkpatch.pl
> +++ b/extras/checkpatch.pl
> @@ -3138,7 +3138,7 @@ sub process {
>                                                 $sum_allowed += $_;
>                                         }
>                                         if ($sum_allowed == 0) {
> -                                               WARN("BRACES",
> +                                               WARN("BRACES_SINGLE_STMT",
>                                                      "braces {} are not necessary for any arm of this statement\n" . $herectx);
>                                         } elsif ($sum_allowed != $allow &&
>                                                  $seen != $allow) {
> --
> 1.7.10.4
>



                 reply	other threads:[~2013-11-13  5:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE_Gge2gApvf-+RmhPeDuD3vEvu4LM6R1OfxGvVPc1Ns3aD6PQ@mail.gmail.com \
    --to=raphael.beamonte@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox