From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 81aVHM5e2GJtTxcAWB0awg (envelope-from ) for ; Wed, 20 Jul 2022 16:00:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 66E961E5EA; Wed, 20 Jul 2022 16:00:14 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=lists.lttng.org header.i=@lists.lttng.org header.a=rsa-sha256 header.s=default header.b=zIUyQQ/0; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.lttng.org (lists.lttng.org [167.114.26.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EC6ED1E21F for ; Wed, 20 Jul 2022 16:00:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.lttng.org; s=default; t=1658347213; bh=Zg/TFjxJGz69adDeMwaDrC6yyqw0a5MhdJ8loJ1tkW4=; h=References:In-Reply-To:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zIUyQQ/0d2+0q2QetRXgQCU/ArqzThU0S/g6xXkDzXuRD0jEu1nnfaCHBCYO5165x pPM0CVCi59urFUxuO8FDMJ4F7geOI9X3jn5tLfkPz9w0+sEFKoM1TLCIldEYF8Z/TG U67BT0DxvBiEgOKDJq2VrhxxQLaVYJ/F1ILZuiXISHCRgp79KdfeMprJ9r9Ild3o9n ohsU7IDn0ys1r8eXdhb8IPXEeZXmty8Sz1hr2AyfeLSvrdRVV7NBFLEIuOiSQJlDKd +CznYHeviGogBp1nIAqpHjngEd4uIfR2Tzp1ToGhzMaNWH24Q2UlpubrJFDsXhiT6H Ri3pk9CliU7Ew== Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4Lp64Y2zmdzQ1V; Wed, 20 Jul 2022 16:00:13 -0400 (EDT) Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by lists.lttng.org (Postfix) with ESMTPS id 4Lp64X4YcVzQCC for ; Wed, 20 Jul 2022 16:00:12 -0400 (EDT) Received: by mail-vk1-xa30.google.com with SMTP id o10so2310406vkl.3 for ; Wed, 20 Jul 2022 13:00:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z+9HnkSs0d3NSoz5LBZ3SPAhZmqlSBX1N5g2o1rw+Ic=; b=hXkWZie8Sm4V8Tb2wQE0MB0K33W2bFSmDSXRd2gbgBH5anzwqafbciOKwEm2wP0+RB wdk2++jHsLAkTLOhq1tkTOiYOwJAkabBMPxySy6fgXzoBlY/4VoJHLZjhJvEMObCO/07 bOQHlLNi+Zg3rWJzt05UUhB9F/0SvRRxSTLzJqcXJE0k/eeSXugxVMEcwBKOB3INh+jc y/Rr0sdu5YDXoPH6Ar/Tcg/6kssAeM0MOJ8XlcvJiaw/3CTOWQpixINRZPgXvIv7kBNs i3IboP5a6DSu2Ud5NqKqsQ1cFY+nbN0jxFk/UJ9UbtKzXzfv4LmdJY2zKLGRtBLKi0mp iTrw== X-Gm-Message-State: AJIora9AsKcssrFhFXdAvwrFeN8017Fcoy4y9IioYihDDH4dXFd8nsiw feV51paYLGMt79C3m84POl2wpP3qSaP6PKcWl40= X-Google-Smtp-Source: AGRyM1ufMUr3fVQ4UxyAVGMQ0KpW6QPwbNmvs6oj1BLfldpEPR8KTyW8ducPR3wRtz0ELWLcwAAdTH4l2AMtZh9OYj4= X-Received: by 2002:a1f:948f:0:b0:374:b54b:d917 with SMTP id w137-20020a1f948f000000b00374b54bd917mr14580260vkd.14.1658347211749; Wed, 20 Jul 2022 13:00:11 -0700 (PDT) MIME-Version: 1.0 References: <20220718215955.124991-1-nolange79@gmail.com> <1399876011.74159.1658259573115.JavaMail.zimbra@efficios.com> In-Reply-To: <1399876011.74159.1658259573115.JavaMail.zimbra@efficios.com> Date: Wed, 20 Jul 2022 22:00:00 +0200 Message-ID: To: Mathieu Desnoyers Cc: lttng-dev Subject: Re: [lttng-dev] [PATCH 1/2] lttng_ust_init_thread: initialise cached context values X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Norbert Lange via lttng-dev Reply-To: Norbert Lange Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" Am Di., 19. Juli 2022 um 21:39 Uhr schrieb Mathieu Desnoyers : > > ----- On Jul 18, 2022, at 5:59 PM, Norbert Lange via lttng-dev lttng-dev@lists.lttng.org wrote: > > > Modify all relevant *_alloc_tls functions so that they take an > > argument for 'init'. Setting this to 'true' will read > > the actual context value and store it into a thread local > > cache. > > > > The function 'lttng_ust_init_thread' will use this to > > precalculate context values. Tracepoints can then avoid > > systemcalls. > > Rather than integrating two unrelated things within "alloc_tls" > functions, I would prefer that we split things like this, e.g.: > > keep lttng_cgroup_ns_alloc_tls() as is. > > Introduce lttng_ust_cgroup_init_thread() which would > call (void)get_cgroup_ns(). > > Likewise for all other contexts. > > Thoughts ? is this just a matter of the function name? The "things" are related as they both prepare the same thread local cache. ie. rename lttng_cgroup_ns_alloc_tls(bool init) to lttng_ust_cgroup_init_thread(bool initcache)? Don't care much either way,I just usually try to limit symbols. Regards, Norbert _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev