From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3v/vDW78rGCtfQAAWB0awg (envelope-from ) for ; Tue, 25 May 2021 09:32:30 -0400 Received: by simark.ca (Postfix, from userid 112) id 2BC731F11C; Tue, 25 May 2021 09:32:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.lttng.org (lists.lttng.org [167.114.26.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE0421E54D for ; Tue, 25 May 2021 09:32:28 -0400 (EDT) Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4FqFPS18ZLz1w9w; Tue, 25 May 2021 09:32:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.lttng.org; s=default; t=1621949548; bh=VWJHcyBu+8n9Ot1utMTZq8yno1hEDCdbg2RL/dMzYKE=; h=References:In-Reply-To:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MdeszGTM7IkbsHPIB3VNK0Bp8Y/m2PG/OZL0nJfPGQsgRgv0CLIPCbFDRtJNTKrnN E3674eyDBbD++P7h3YrNfIxabgdAkfcn5KwSpPM4Mrk5nYfBTVoY6EX1SdUfyv6c4w H1+2vNP7+hZoXc9x3c1ngBDRUKW7F4vXM97DTOi0psW/0JsWsI0fWxMeH1QDB7whZt wpdgeFJFo1EP+/sriHbfGcx9IqJkMg/nhOSfCW7Cld/argloVKBp83+FISusBoud63 ngY/M6QghUK9BZDhQVArZzv9NgM/iWsMGUAwGl0jV86Mvl0vbB53bxXtdeHFV6sNtR V/3zXfZfFVBlw== Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lists.lttng.org (Postfix) with ESMTPS id 4FqFPR1vmWz1w9v for ; Tue, 25 May 2021 09:32:27 -0400 (EDT) Received: by mail-ot1-x336.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so28582173otg.2 for ; Tue, 25 May 2021 06:32:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0cOObiyoOLCeaZdxFQsMv8Z1b4lJfJ9jHLtz4aro4OY=; b=l/xfFiFQzndL1plb3mklarTAxJ/0eitH9z0zyRTKXkY5EvnQ7zesrU1lVVNAB+roZS Qqru1J5VdnPrEAw4bAbdCiQLeUESv7ls/jWGwIxo2mOkGsoVHexOE5qSSWOCRLBzjjT3 eXjTGPwdTitYSibMcXu0tF1BHmRP+XjUCeber4nXiiIjWYL44/SJyxmVS253iz/J44nU NgTigtwPGnwEmrLpDW4NIzFgWkLTRR4eKHguhFAZQ5Nv8MWQ/7XMAcCzUiI1fvgpxOuF VYQ5Vcls9B5In8J3Oen5CiSXNcgwmy6yDQn9WzBSbDZNSw48k45M3A36b1Wdd2ZXMPib ++6A== X-Gm-Message-State: AOAM533a0hSGoL3BHVPTzFXcP4tv/EbaEvmA8u6aKusQ7OYAUPN5e55k hgDaQT9pvqND4HjSnMe+nBINx1tSLjXbDza486A= X-Google-Smtp-Source: ABdhPJzBMF/x+miwGKfXZH+bUZKjGRgCQeMLSoaz1OuD1GrLspz1bJPCFPBKZD42bb4u6ntVEbOBTW1mUq+bnGTYNdk= X-Received: by 2002:a9d:7612:: with SMTP id k18mr22872103otl.178.1621949546337; Tue, 25 May 2021 06:32:26 -0700 (PDT) MIME-Version: 1.0 References: <20210520121807.55428-1-nolange79@gmail.com> <1600729511.52338.1621520352970.JavaMail.zimbra@efficios.com> <982122605.52445.1621524098787.JavaMail.zimbra@efficios.com> <523808152.52514.1621527935563.JavaMail.zimbra@efficios.com> <154847626.52635.1621531127222.JavaMail.zimbra@efficios.com> In-Reply-To: <154847626.52635.1621531127222.JavaMail.zimbra@efficios.com> Date: Tue, 25 May 2021 15:32:15 +0200 Message-ID: To: Mathieu Desnoyers Cc: lttng-dev Subject: Re: [lttng-dev] [PATCH lttng-ust] Improve tracelog handling, reduce exported functions X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Norbert Lange via lttng-dev Reply-To: Norbert Lange Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" Am Do., 20. Mai 2021 um 19:18 Uhr schrieb Mathieu Desnoyers : > > > > ----- On May 20, 2021, at 12:51 PM, Norbert Lange nolange79@gmail.com wrote: > > > Am Do., 20. Mai 2021 um 18:25 Uhr schrieb Mathieu Desnoyers > > : > >> > >> ----- On May 20, 2021, at 11:54 AM, Norbert Lange nolange79@gmail.com wrote: > >> [...] > >> > >> >> What prevents you from linking against lttng-ust.so again ? > >> > > >> > I did not poke around enough with Lttng to be confident it wont have > >> > side effects, > >> > I really don't want it active in production. It doesn't seem there is > >> > much public knowledge with Xenomai either. > >> > lttng-ust.so will spawn threads, lttng-ust-tracepoint.so is mostly passive, > >> > >> There is indeed a split between instrumentation and runtime threads done > >> with lttng-ust-tracepoint.so vs lttng-ust.so. > >> > >> I understand that this split is missing for tracelog and tracef, and > >> would be a good thing to have. > >> > >> I would be interested to move the tracelog and tracef implementation > >> from liblttng-ust.so to liblttng-ust-tracepoint.so, even this late > >> in the -rc cycle, because all users of tracelog/tracef need to link > >> against liblttng-ust-tracepoint.so anyway. So moving these symbols > >> should not affect anyone. > >> > >> Can you give it a try and let me know if it works for you ? > > > > Will take some time, whats the timeframe you need for feedback? > > Here is the tentative commit: > > https://review.lttng.org/c/lttng-ust/+/5927 Move tracef/tracelog symbols to liblttng-ust-tracepoint.so > Make a own thread for this? I testet this, but get errors as liblttng-ust-tracepoint.so depends on symbols from liblttng-ust.so. /usr/lib/gcc/x86_64-linux-gnu/10/../../../../x86_64-linux-gnu/bin/ld: /tmp/opt/hipase2/buildroot-acpu/host/x86_64-buildroot-linux-gnu/sysroot/lib/../lib64/liblttng-ust-tracepoint.so: undefined reference to `lttng_ust_probe_register' /usr/lib/gcc/x86_64-linux-gnu/10/../../../../x86_64-linux-gnu/bin/ld: /tmp/opt/hipase2/buildroot-acpu/host/x86_64-buildroot-linux-gnu/sysroot/lib/../lib64/liblttng-ust-tracepoint.so: undefined reference to `lttng_ust_probe_unregister' _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev