From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id L0xsDfB4pmC3XAAAWB0awg (envelope-from ) for ; Thu, 20 May 2021 10:57:52 -0400 Received: by simark.ca (Postfix, from userid 112) id 2F9EF1F11C; Thu, 20 May 2021 10:57:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_REPLYTO_END_DIGIT,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from lists.lttng.org (lists.lttng.org [167.114.26.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 90A391E54D for ; Thu, 20 May 2021 10:57:51 -0400 (EDT) Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4FmCXG6rxKz1rpq; Thu, 20 May 2021 10:57:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.lttng.org; s=default; t=1621522671; bh=wpN7pYcQZ9+QbzD1nwTjlYkvkwd+fOCzVZm0+7xez80=; h=References:In-Reply-To:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fvBFZvLVpg914oELAMNVunenHmBTFgDHwTLre4njAt0z5pvL5FnBmd8V5XGrKUuUO fyC7GVStuaFLMIlbYvYcKT2+bG1BG5MHiLc8zy9IusE6F0njRxyZ73eQ6egjz1EXUb LVvzjKnJ2x8zdIr6zGLlIx8C2qj5CbRanOJgCJ/S44z8vG3IzsV1PCXcf7vdcFDkfo ionPbmCssFmkgxbLVUdWdZsd3NH97WSCm4gUNgtx5IujtnPQ8C1u/SqTwFicgVZ+it Ei2c8pE8T9l4+lYRIgpDtjL7Le/0K+MtPZ07aRhYJ34SAaGSOg+CYsZb9ls4iT7Bjl RXOGAQ2KPC1ww== Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lists.lttng.org (Postfix) with ESMTPS id 4FmCXF6898z1rRs for ; Thu, 20 May 2021 10:57:49 -0400 (EDT) Received: by mail-oi1-x235.google.com with SMTP id t24so1150381oiw.3 for ; Thu, 20 May 2021 07:57:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZZ4muay611VG0uVKYyp/5ND7zY1Cdj5DRw807RST8+E=; b=h1J/3zdNSE4AC1GOdy/l74BYSXy+ePfZZa4IUuxBs+wMTo4nVua7YFZKJi0wl4LWDa mmb/dweGnqpaR0YgHxtkdlciqhduWQSHf51ZMSyvH2HHl8FWkPJMYCsfCr4ekKQSwEYw YOEPB9PjptKgbVrsA2Q6Xz8lp/Qza+ItQzbxRSSyx2YSiA43S2fbns8BfH9WJrHqEfxT rBn7LVZYmWd2PkWVh207p2+lkTPc9Wmfyez9PTZpnM1x353gvOK9kEdDJIY2Q1GYeWcW m+SmriI+epirsnMi75A0wHnYVnLMNf7+hB5jbCat05rWh2GtjSOSB/wWf9DTnHAnwImC Hb7Q== X-Gm-Message-State: AOAM5313mxZy8SRvtVMyHFFcCU9tFv6UTMQU4wgK09s7wfv/7nv4rI2J p+BEwMFrl6C8wrgXNOme/xFiwRN8Jm7HSPkxFp8= X-Google-Smtp-Source: ABdhPJz2pKI9iL7qlWaNR3NGm43ZCSfP8WKlcT/Vv5i7RDmMbMFZudWAH7awxsjssUkd7zR7pT3J77Dd1bZLzR36JYU= X-Received: by 2002:aca:acc7:: with SMTP id v190mr3629965oie.28.1621522669029; Thu, 20 May 2021 07:57:49 -0700 (PDT) MIME-Version: 1.0 References: <20210520121807.55428-1-nolange79@gmail.com> <1600729511.52338.1621520352970.JavaMail.zimbra@efficios.com> In-Reply-To: <1600729511.52338.1621520352970.JavaMail.zimbra@efficios.com> Date: Thu, 20 May 2021 16:57:38 +0200 Message-ID: To: Mathieu Desnoyers Cc: lttng-dev Subject: Re: [lttng-dev] [PATCH lttng-ust] Improve tracelog handling, reduce exported functions X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Norbert Lange via lttng-dev Reply-To: Norbert Lange Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" Am Do., 20. Mai 2021 um 16:19 Uhr schrieb Mathieu Desnoyers : > > ----- On May 20, 2021, at 8:18 AM, lttng-dev lttng-dev@lists.lttng.org wrote: > > > Instead of creating functions for each loglevel, simply pass the > > callback as argument. > > > > Further pack all preprocessor information into a struct that > > the compiler already can prepare. > > This introduces an ABI break too late in the cycle. So 2.14 would be the next chance I guess > Also, I'm not so keen on adding an indirect call on the fast-path > when it's not absolutely needed. Code seems pretty similar: https://godbolt.org/z/oK1WhWqGT > What is wrong with having one symbol per loglevel ? Macro-magic is cumbersome to edit, more code, more relocations. Easier to adapt aswell, could roll my own tracelog functions while using lttng_ust__tracelog_printf (started soind that as I don't want to link to lttng-ust.so) Norbert _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev