Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: jeremie.galarneau@efficios.com (Jérémie Galarneau)
Subject: [lttng-dev] [PATCH lttng-tools] Fix: add subdir-objects to Makefile.am
Date: Mon, 21 Sep 2015 12:19:42 -0400	[thread overview]
Message-ID: <CA+jJMxujRvCaLT9yHBur2mfD5wNESyc8GFTTBMn-YO-cdCFhfg@mail.gmail.com> (raw)
In-Reply-To: <1442516950-22760-1-git-send-email-mathieu.desnoyers@efficios.com>

Merged in master and stable-2.7.

Thanks!
J?r?mie

On Thu, Sep 17, 2015 at 3:09 PM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> Fixes the following warning introduced by the runas worker changes. Use
> the same technique used in src/bin/lttng/Makefile.am.
>
> src/common/Makefile.am:17: warning: source file 'sessiond-comm/unix.c' is in a subdirectory,
> src/common/Makefile.am:17: but option 'subdir-objects' is disabled
> automake: warning: possible forward-incompatibility.
> automake: At least a source file is in a subdirectory, but the 'subdir-objects'
> automake: automake option hasn't been enabled.  For now, the corresponding output
> automake: object file(s) will be placed in the top-level directory.  However,
> automake: this behaviour will change in future Automake versions: they will
> automake: unconditionally cause object files to be placed in the same subdirectory
> automake: of the corresponding sources.
> automake: You are advised to start using 'subdir-objects' option throughout your
> automake: project, to avoid future incompatibilities.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  src/common/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/common/Makefile.am b/src/common/Makefile.am
> index 64110e6..5b71612 100644
> --- a/src/common/Makefile.am
> +++ b/src/common/Makefile.am
> @@ -1,5 +1,7 @@
>  AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/src
>
> +AUTOMAKE_OPTIONS = subdir-objects
> +
>  SUBDIRS = compat health hashtable kernel-ctl sessiond-comm relayd \
>                   kernel-consumer ust-consumer testpoint index config
>
> --
> 2.1.4
>



-- 
J?r?mie Galarneau
EfficiOS Inc.
http://www.efficios.com



           reply	other threads:[~2015-09-21 16:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1442516950-22760-1-git-send-email-mathieu.desnoyers@efficios.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+jJMxujRvCaLT9yHBur2mfD5wNESyc8GFTTBMn-YO-cdCFhfg@mail.gmail.com \
    --to=jeremie.galarneau@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox