From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeremie.galarneau@efficios.com (=?UTF-8?Q?J=C3=A9r=C3=A9mie_Galarneau?=) Date: Mon, 21 Sep 2015 12:19:45 -0400 Subject: [lttng-dev] [PATCH lttng-tools] Fix: tests: skip UST perf tests if not root In-Reply-To: <1442513450-8013-1-git-send-email-mathieu.desnoyers@efficios.com> References: <1442513450-8013-1-git-send-email-mathieu.desnoyers@efficios.com> Message-ID: Merged in master and stable-2.7. I have also moved the test from the "fast_regression" to "root_regression" test list. Thanks! J?r?mie On Thu, Sep 17, 2015 at 2:10 PM, Mathieu Desnoyers wrote: > Some distributions like Debian (e.g. Debian kernel 4.1.0-2-amd64) have > some grsecurity options enabled, such as CONFIG_GRKERNSEC_PERF_HARDEN. > > Unfortunately, this option makes it impossible to use the SW page-fault > perf event as a normal user. It only leaves some HW events. However, we > can only use SW events within virtual machines. > > Therefore, only run this test as root for now until we find a better > approach. > > Signed-off-by: Mathieu Desnoyers > --- > tests/regression/ust/test_event_perf | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/tests/regression/ust/test_event_perf b/tests/regression/ust/test_event_perf > index 7fb37ed..7dc2168 100755 > --- a/tests/regression/ust/test_event_perf > +++ b/tests/regression/ust/test_event_perf > @@ -90,8 +90,17 @@ plan_tests $NUM_TESTS > > print_test_banner "$TEST_DESC" > > -start_lttng_sessiond > +if [ "$(id -u)" == "0" ]; then > + isroot=1 > +else > + isroot=0 > +fi > + > +skip $isroot "Root access is needed. Skipping UST perf tests." ${NUM_TESTS} || > +{ > + start_lttng_sessiond > > -test_event_basic > + test_event_basic > > -stop_lttng_sessiond > + stop_lttng_sessiond > +} > -- > 2.1.4 > -- J?r?mie Galarneau EfficiOS Inc. http://www.efficios.com