Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: jeremie.galarneau@efficios.com (Jérémie Galarneau)
Subject: [lttng-dev] [PATCH babeltrace] Fix: text output missing separator when printing the domain
Date: Fri, 26 May 2017 09:36:44 -0400	[thread overview]
Message-ID: <CA+jJMxtfBAUioMMW-mZCKT4Lak5C+X_egDs696oX7w4U7w0AYw@mail.gmail.com> (raw)
In-Reply-To: <1489781723-23942-1-git-send-email-jdesfossez@efficios.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

Merged in master, stable-1.5, and stable-1.4. Thanks!

Jérémie

On 17 March 2017 at 16:15, Julien Desfossez <jdesfossez at efficios.com> wrote:
> With the "-f all" option, we expect to see
> <hostname>:<domain>:<loglevel>, but instead we see
> <hostname><domain>:<loglevel>.
>
> Judging from the pattern of the other printed fields, the check for
> "dom_print" variable seems to be missing when printing the domain.
>
> Signed-off-by: Julien Desfossez <jdesfossez at efficios.com>
> ---
>  formats/ctf-text/ctf-text.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/formats/ctf-text/ctf-text.c b/formats/ctf-text/ctf-text.c
> index f615161..69450cf 100644
> --- a/formats/ctf-text/ctf-text.c
> +++ b/formats/ctf-text/ctf-text.c
> @@ -350,6 +350,8 @@ int ctf_text_write_event(struct bt_stream_pos *ppos, struct ctf_stream_definitio
>                 set_field_names_print(pos, ITEM_HEADER);
>                 if (pos->print_names) {
>                         fprintf(pos->fp, "trace:domain = ");
> +               } else if (dom_print) {
> +                       fprintf(pos->fp, ":");
>                 }
>                 fprintf(pos->fp, "%s", stream_class->trace->env.domain);
>                 if (pos->print_names)
> --
> 2.7.4
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com


           reply	other threads:[~2017-05-26 13:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1489781723-23942-1-git-send-email-jdesfossez@efficios.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+jJMxtfBAUioMMW-mZCKT4Lak5C+X_egDs696oX7w4U7w0AYw@mail.gmail.com \
    --to=jeremie.galarneau@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox