From: jeremie.galarneau@efficios.com (Jérémie Galarneau)
Subject: [lttng-dev] [PATCH lttng-tools 06/10] Fix: error.h: add missing parenthesis around macro parameter
Date: Thu, 19 May 2016 00:13:15 -0400 [thread overview]
Message-ID: <CA+jJMxtRgYj0sYj-9mcJCZnUgR1LG4D6gbxBrnis4-OxTBfCHw@mail.gmail.com> (raw)
In-Reply-To: <1463594659-10964-7-git-send-email-mathieu.desnoyers@efficios.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2510 bytes --]
Merged, thanks!
Jérémie
On Wed, May 18, 2016 at 2:04 PM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
> src/common/error.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/common/error.h b/src/common/error.h
> index 3ab1d46..ca5af86 100644
> --- a/src/common/error.h
> +++ b/src/common/error.h
> @@ -75,18 +75,18 @@ extern int lttng_opt_mi;
> */
> #define __lttng_print(type, fmt, args...) \
> do { \
> - if (!lttng_opt_quiet&& !lttng_opt_mi && \
> - type == PRINT_MSG) { \
> + if (!lttng_opt_quiet && !lttng_opt_mi && \
> + (type) == PRINT_MSG) { \
> fprintf(stdout, fmt, ## args); \
> } else if (!lttng_opt_quiet && !lttng_opt_mi && \
> - (((type & PRINT_DBG) && lttng_opt_verbose == 1) || \
> - ((type & (PRINT_DBG | PRINT_DBG2)) && \
> + ((((type) & PRINT_DBG) && lttng_opt_verbose == 1) || \
> + (((type) & (PRINT_DBG | PRINT_DBG2)) && \
> lttng_opt_verbose == 2) || \
> - ((type & (PRINT_DBG | PRINT_DBG2 | PRINT_DBG3)) && \
> + (((type) & (PRINT_DBG | PRINT_DBG2 | PRINT_DBG3)) && \
> lttng_opt_verbose == 3))) { \
> fprintf(stderr, fmt, ## args); \
> } else if (!lttng_opt_quiet && \
> - (type & (PRINT_WARN | PRINT_ERR | PRINT_BUG))) { \
> + ((type) & (PRINT_WARN | PRINT_ERR | PRINT_BUG))) { \
> fprintf(stderr, fmt, ## args); \
> } \
> } while (0);
> --
> 2.1.4
>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2016-05-19 4:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 18:04 [lttng-dev] [PATCH lttng-tools 00/10] Fix: tracefile rotation rm-after-destroy race Mathieu Desnoyers
2016-05-18 18:04 ` [lttng-dev] [PATCH lttng-tools 06/10] Fix: error.h: add missing parenthesis around macro parameter Mathieu Desnoyers
2016-05-19 4:13 ` Jérémie Galarneau [this message]
2016-05-18 18:04 ` [lttng-dev] [PATCH lttng-tools 07/10] Fix: WARN() should print as WARN level, not ERR Mathieu Desnoyers
2016-05-19 4:14 ` Jérémie Galarneau
2016-05-18 18:04 ` [lttng-dev] [PATCH lttng-tools 08/10] Add environment variable to allow abort on error Mathieu Desnoyers
2016-05-19 4:45 ` Jérémie Galarneau
2016-05-18 18:04 ` [lttng-dev] [PATCH lttng-tools 09/10] test: kernel tracing destroy flush behavior with tracefile rotation Mathieu Desnoyers
2016-05-19 4:45 ` Jérémie Galarneau
2016-05-18 18:04 ` [lttng-dev] [PATCH lttng-tools 10/10] test: UST " Mathieu Desnoyers
2016-05-19 4:46 ` Jérémie Galarneau
[not found] ` <1463594659-10964-2-git-send-email-mathieu.desnoyers@efficios.com>
2016-05-19 2:57 ` [lttng-dev] [PATCH lttng-tools 01/10] Fix: bad file descriptors on close after rotation error Jérémie Galarneau
[not found] ` <1463594659-10964-3-git-send-email-mathieu.desnoyers@efficios.com>
2016-05-19 4:09 ` [lttng-dev] [PATCH lttng-tools 02/10] Fix: UST should not generate packet at destroy after stop Jérémie Galarneau
[not found] ` <1463594659-10964-4-git-send-email-mathieu.desnoyers@efficios.com>
2016-05-19 4:09 ` [lttng-dev] [PATCH lttng-tools 03/10] Fix: kernel tracing: flush " Jérémie Galarneau
[not found] ` <1463594659-10964-5-git-send-email-mathieu.desnoyers@efficios.com>
2016-05-19 4:12 ` [lttng-dev] [PATCH lttng-tools 04/10] Fix: ust-consumer: flush empty packets on snapshot channel Jérémie Galarneau
[not found] ` <1463594659-10964-6-git-send-email-mathieu.desnoyers@efficios.com>
2016-05-19 4:12 ` [lttng-dev] [PATCH lttng-tools 05/10] Fix: bogus mask on error.h PRINT types Jérémie Galarneau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+jJMxtRgYj0sYj-9mcJCZnUgR1LG4D6gbxBrnis4-OxTBfCHw@mail.gmail.com \
--to=jeremie.galarneau@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox