Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: jeremie.galarneau@efficios.com (Jérémie Galarneau)
Subject: [lttng-dev] [PATCH lttng-tools] Fix: unchecked return value in low throughput test
Date: Wed, 18 May 2016 16:07:35 -0400	[thread overview]
Message-ID: <CA+jJMxs2RNo4NK8J1vjku5bo28hr6=Nx4w72UacyETokFK0gLQ@mail.gmail.com> (raw)
In-Reply-To: <1463502164-11198-1-git-send-email-mathieu.desnoyers@efficios.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Merged, thanks!

Jérérmie

On Tue, May 17, 2016 at 12:22 PM, Mathieu Desnoyers
<mathieu.desnoyers at efficios.com> wrote:
> Found by Coverity:
>
> CID 1019967 (#1 of 1): Unchecked return value from library
> (CHECKED_RETURN)2. check_return: Calling poll(NULL, 0UL, 60000) without
> checking return value. This library function may fail and return an
> error code.
>
> We really don't care whether this poll succeeds or not.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> ---
>  tests/regression/ust/low-throughput/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/regression/ust/low-throughput/main.c b/tests/regression/ust/low-throughput/main.c
> index 06ab9ef..b1c38bc 100644
> --- a/tests/regression/ust/low-throughput/main.c
> +++ b/tests/regression/ust/low-throughput/main.c
> @@ -34,7 +34,7 @@ static void *th_event_minute(void *data)
>         /* Loop for 20 minutes */
>         for (i = 1; i < 21; i++) {
>                 /* Sleep 60 seconds */
> -               poll(NULL, 0, 60000);
> +               (void) poll(NULL, 0, 60000);
>
>                 /* 20 minutes tracepoint */
>                 if ((i % 20) == 0) {
> --
> 2.1.4
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com


           reply	other threads:[~2016-05-18 20:07 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1463502164-11198-1-git-send-email-mathieu.desnoyers@efficios.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+jJMxs2RNo4NK8J1vjku5bo28hr6=Nx4w72UacyETokFK0gLQ@mail.gmail.com' \
    --to=jeremie.galarneau@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox