From mboxrd@z Thu Jan  1 00:00:00 1970
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Date: Wed, 23 Feb 2011 10:40:05 -0500
Subject: [ltt-dev] [UST PATCH] libust: Fix multiple fd close during fork
In-Reply-To: <alpine.DEB.2.00.1102231654440.30437@as68123.uab.ericsson.se>
References: <1298464816-19832-1-git-send-email-nils.carlson@ericsson.com>
	<alpine.DEB.2.00.1102231340470.30437@as68123.uab.ericsson.se>
	<4D651DD0.8070805@gmail.com>
	<alpine.DEB.2.00.1102231654440.30437@as68123.uab.ericsson.se>
Message-ID: <BLU0-SMTP12AF1BA7103415A83A524F96DB0@phx.gbl>

* Nils Carlson (nils.carlson at ericsson.com) wrote:
> Yep. fixed. merged.
>
>>>> +    /*
>>>> +     * FIXME: This could be prettier, we loop over the list twice and
>>>> +     * following good locking practice should lock around the loop
>>>> +     */
>>>> +    cds_list_for_each_entry_safe(trace, trace_tmp, &ltt_traces.head,
>>>> list) {
>>>> +        ltt_trace_destroy(trace->trace_name, 1);
>>>> +    }

So what' up with these missing locks ?

Mathieu

>>>>
>>>>     /* Clean up the listener socket and epoll, keeping the scoket
>>>> file */
>>>>     ustcomm_del_named_sock(listen_sock, 1);
>>>> --
>>>> 1.7.1
>>>>
>>>>
>>
>>
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com