From: Michael Jeanson via lttng-dev <lttng-dev@lists.lttng.org>
To: yashvardhan kukreti <yashvardhankukreti@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: lttng-dev@lists.lttng.org
Subject: Re: [lttng-dev] https://lists.lttng.org/pipermail/lttng-dev/2020-May/029631.html
Date: Mon, 27 Mar 2023 14:29:26 -0400 [thread overview]
Message-ID: <9bf67681-e3c7-0b25-07b7-40c0a85aee67@efficios.com> (raw)
In-Reply-To: <CALx39aqPFVKGCv+jqvgdxge6mew0+Wg4cH-PnBB8Z_LhO6rOig@mail.gmail.com>
On 2023-03-27 11:52, yashvardhan kukreti wrote:
> 62 #ifdef LTTNG_CONFIG_PPC64_ELF_ABI_V2
> 63 /* Substract 4 bytes to get what we originally want */
> 64 addr = (unsigned long)(((char *)probe.addr) - 4);
> 65 #elif defined*(LTTNG_*CONFIG_PPC64_ELF_ABI_V1) << incorrect MACRO to
> used in gerrit review. this is the correct one.
> 66 /*
> 67 * Build a function descriptor from the address of
>
> /lttng-module-2.13.8/src/wrapper/kallsyms.c:72:32: error: invalid use of
> undefined type 'struct func_desc'
> | 72 | kallsyms_lookup_name_func_desc.addr = (unsigned long)probe.addr;
> /lttng-module-2.13.8/src/wrapper/kallsyms.c:73:32: error: invalid use of
> undefined type 'struct func_desc'
> | 73 | kallsyms_lookup_name_func_desc.toc = ((struct func_desc *)
> &sprint_symbol)->toc;
>
> you either want to use func_descr_t
> https://elixir.bootlin.com/linux/v5.15.104/source/arch/powerpc/include/asm/types.h#L30 <https://elixir.bootlin.com/linux/v5.15.104/source/arch/powerpc/include/asm/types.h#L30>
> or
> struct ppc64_opd_entry
> https://elixir.bootlin.com/linux/v5.17.15/source/arch/powerpc/include/uapi/asm/elf.h#L293 <https://elixir.bootlin.com/linux/v5.17.15/source/arch/powerpc/include/uapi/asm/elf.h#L293>
>
> both of which are discontinued from 5.18
Hi,
I updated the patch at https://review.lttng.org/c/lttng-modules/+/9113 to
support kernels older than v5.18. It's only build tested on v5.17 and v5.18.
Michael
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2023-03-27 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALx39aqN_YvfcDhhKgURZZU-bWZvuiZptbb-kJDYerEex9Q-7A@mail.gmail.com>
2023-03-26 15:00 ` yashvardhan kukreti via lttng-dev
2023-03-27 12:27 ` Mathieu Desnoyers via lttng-dev
2023-03-27 15:52 ` yashvardhan kukreti via lttng-dev
2023-03-27 18:29 ` Michael Jeanson via lttng-dev [this message]
2023-03-28 13:34 ` yashvardhan kukreti via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf67681-e3c7-0b25-07b7-40c0a85aee67@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mjeanson@efficios.com \
--cc=yashvardhankukreti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox