From: ktkhai@virtuozzo.com (Kirill Tkhai)
Subject: [lttng-dev] [PATCH v3] mm: Rename mm_vmscan_lru_shrink_inactive trace event variables
Date: Thu, 23 May 2019 19:13:10 +0300 [thread overview]
Message-ID: <8d4cd39d-6bca-4161-7134-ac05ffa590b3@virtuozzo.com> (raw)
In-Reply-To: <a187c72c-9ca2-7668-fc60-e9c310c30d5c@gydle.com>
Rename nr_activate{0,1} into nr_activate_{anon,file} since this
is exported into userspace, e.g., it's shown here:
/sys/kernel/debug/tracing/events/vmscan/mm_vmscan_lru_shrink_inactive/format
v3: Fix comment
v2: Changed suggested person
Suggested-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Signed-off-by: Kirill Tkhai <ktkhai at virtuozzo.com>
---
include/trace/events/vmscan.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index a5ab2973e8dc..c316279715f4 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -348,8 +348,8 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
__field(unsigned long, nr_writeback)
__field(unsigned long, nr_congested)
__field(unsigned long, nr_immediate)
- __field(unsigned int, nr_activate0)
- __field(unsigned int, nr_activate1)
+ __field(unsigned int, nr_activate_anon)
+ __field(unsigned int, nr_activate_file)
__field(unsigned long, nr_ref_keep)
__field(unsigned long, nr_unmap_fail)
__field(int, priority)
@@ -364,8 +364,8 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
__entry->nr_writeback = stat->nr_writeback;
__entry->nr_congested = stat->nr_congested;
__entry->nr_immediate = stat->nr_immediate;
- __entry->nr_activate0 = stat->nr_activate[0];
- __entry->nr_activate1 = stat->nr_activate[1];
+ __entry->nr_activate_anon = stat->nr_activate[0];
+ __entry->nr_activate_file = stat->nr_activate[1];
__entry->nr_ref_keep = stat->nr_ref_keep;
__entry->nr_unmap_fail = stat->nr_unmap_fail;
__entry->priority = priority;
@@ -377,7 +377,7 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive,
__entry->nr_scanned, __entry->nr_reclaimed,
__entry->nr_dirty, __entry->nr_writeback,
__entry->nr_congested, __entry->nr_immediate,
- __entry->nr_activate0, __entry->nr_activate1,
+ __entry->nr_activate_anon, __entry->nr_activate_file,
__entry->nr_ref_keep, __entry->nr_unmap_fail,
__entry->priority,
show_reclaim_flags(__entry->reclaim_flags))
prev parent reply other threads:[~2019-05-23 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 8:44 [lttng-dev] [PATCH] " Kirill Tkhai
2019-05-22 10:17 ` [lttng-dev] [PATCH v2] " Kirill Tkhai
2019-05-22 14:39 ` Sebastien Boisvert
2019-05-23 16:13 ` Kirill Tkhai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d4cd39d-6bca-4161-7134-ac05ffa590b3@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox