From mboxrd@z Thu Jan  1 00:00:00 1970
From: vilanova@ac.upc.edu (=?utf-8?Q?Llu=C3=ADs_Vilanova?=)
Date: Tue, 20 Sep 2011 14:55:02 +0200
Subject: [ltt-dev] [Qemu-devel] [PATCH 2/3] trace: [ust] Do not use 'm'
	in event argument names (used	by ust macros)
In-Reply-To: <20110920115202.GB23976@stefanha-thinkpad.localdomain> (Stefan
	Hajnoczi's message of "Tue, 20 Sep 2011 12:52:02 +0100")
References: <20110916165933.16620.4383.stgit@ginnungagap.bsc.es>
	<20110916165938.16620.54932.stgit@ginnungagap.bsc.es>
	<20110920115202.GB23976@stefanha-thinkpad.localdomain>
Message-ID: <87ty87z849.fsf@ginnungagap.bsc.es>

Stefan Hajnoczi writes:

> On Fri, Sep 16, 2011 at 06:59:38PM +0200, Llu?s Vilanova wrote:
>> Signed-off-by: Llu?s Vilanova <vilanova at ac.upc.edu>
>> ---
>> trace-events |    4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/trace-events b/trace-events
>> index 9d1fbbb..b653d70 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ"
>> # hw/milkymist-softusb.c
>> milkymist_softusb_memory_read(uint32_t addr, uint32_t value) "addr %08x value %08x"
>> milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "addr %08x value %08x"
>> -milkymist_softusb_mevt(uint8_t m) "m %d"
>> -milkymist_softusb_kevt(uint8_t m) "m %d"
>> +milkymist_softusb_mevt(uint8_t _m) "m %d"
>> +milkymist_softusb_kevt(uint8_t _m) "m %d"

> The LTTng community has been very responsive in addressing namespace
> issues with libust.  Let's post more details and see if it can be fixed
> in libust.

> Could you please post your gcc and libust versions?

> I have not been able to reproduce the problem on Debian libust-dev
> 0.15-3.  My gcc version is Debian gcc 4.6.1-4.

Yup, I was using libust-dev 0.5 (debian stable). After switching to 0.15 (debian
testing) other problems arise.

For example, in my box compiling osdep.c yields lots of "variable ?__tp_cb_data?
set but not used", but using a minimal example does not raise such problems, so
I'm assuming this is related to some namespace problems related to some other
code in qemu's headers.

Unfortunately, right now I have no time to debug the causes, so I'll just assume
the two patches I sent (this naming issue and the zero-length printf format) are
just no longer necessary with recent versions of libust.


Thanks,
    Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth