From: mjeanson@efficios.com (Michael Jeanson)
Subject: [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST
Date: Thu, 28 Apr 2016 18:28:49 +0000 (UTC) [thread overview]
Message-ID: <808373029.72582.1461868129007.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <1d03bf34bd523c31ab8d32e7abda56ec@simark.ca>
----- On Apr 28, 2016, at 12:44 PM, Simon Marchi simon.marchi at polymtl.ca wrote:
>
> Ok thanks.
>
> Just an idea: I find it quite cumbersome to add a new entry in
> configure.ac for each test script that we want autoconf to process (such
> as in patch 3/3). I think it could be easier to have a single file
> (e.g. vars.sh) and have it contain definitions of various directories:
>
> srcdir=@srcdir@
> top_srcdir=@top_srcdir@
> abs_top_srcdir=@abs_top_srcdir@
> builddir=@builddir@
> ...
>
> This way, you could have only a single generated file (vars.sh.in ->
> vars.sh), and each test script would just have to source that file to
> use the values.
As discussed on #lttng, here is the PR resulting from my updates to your
patches :
https://github.com/efficios/babeltrace/pull/43
Concerning the include file, I'm not convinced it would be simpler, we would
end up with static scripts in the source dir including a generated file in
the builddir.
next prev parent reply other threads:[~2016-04-28 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 2:52 Simon Marchi
2016-04-28 2:52 ` [lttng-dev] [PATCH 2/3] tests/lib/Makefile.am: use DISTCLEANFILES instead of CLEANFILES Simon Marchi
2016-04-28 2:52 ` [lttng-dev] [PATCH 3/3] tests/lib: Make test_dwarf and test_bin_info tests work out-of-tree Simon Marchi
2016-04-28 3:04 ` [lttng-dev] [PATCH 1/3] tests/lib/Makefile.am: Remove test_seek_empty_packet and test_seek_big_trace from SCRIPT_LIST Simon Marchi
2016-04-28 16:16 ` Michael Jeanson
2016-04-28 16:44 ` Simon Marchi
2016-04-28 17:53 ` Jérémie Galarneau
2016-04-28 18:28 ` Michael Jeanson [this message]
2016-04-28 18:36 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=808373029.72582.1461868129007.JavaMail.zimbra@efficios.com \
--to=mjeanson@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox