From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: Martin Hicks <martin@sr-research.com>, lttng-dev@lists.lttng.org
Subject: Re: [PATCH] lttng-modules fix for RHEL 9.5 kernels
Date: Tue, 21 Jan 2025 14:56:28 -0500 [thread overview]
Message-ID: <7127ac1b-7cc5-4f98-afe8-1244c3a5056b@efficios.com> (raw)
In-Reply-To: <20250115142300.vlupsqd2lr5bipfo@martin-pc>
On 2025-01-15 09:23, Martin Hicks via lttng-dev wrote:
>
> This fixes the asoc_snd_*, kfree_skb and udp related tracepoints for the
> RHEL 9.5 distro kernel.
>
> In all cases they've updated to the format of newer kernels.
I notice that this patch appears to be based on stable-2.13 rather
than the master branch.
I will apply it to master and forward port it to master, as the
cherry-pick seems trivial, but ideally please submit patches
against the master branch of lttng-modules in the future.
Thanks!
Mathieu
>
> Signed-off-by: Martin Hicks <martin@sr-research.com>
> ---
> include/instrumentation/events/asoc.h | 8 ++++++--
> include/instrumentation/events/skb.h | 4 +++-
> include/instrumentation/events/udp.h | 4 +++-
> 3 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/include/instrumentation/events/asoc.h b/include/instrumentation/events/asoc.h
> index f6b2c76..31bedfe 100644
> --- a/include/instrumentation/events/asoc.h
> +++ b/include/instrumentation/events/asoc.h
> @@ -120,7 +120,9 @@ LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(asoc_snd_soc_preg, snd_soc_preg_read,
> )
> #endif
>
> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,9,0))
> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,9,0) || \
> + LTTNG_RHEL_KERNEL_RANGE(5,14,0,503,21,1, 5,15,0,0,0,0))
> +
> LTTNG_TRACEPOINT_EVENT_CLASS(asoc_snd_soc_dapm_context,
>
> TP_PROTO(struct snd_soc_dapm_context *dapm, int val),
> @@ -187,7 +189,9 @@ LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(asoc_snd_soc_card, snd_soc_bias_level_done,
> )
> #endif
>
> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,9,0))
> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,9,0) || \
> + LTTNG_RHEL_KERNEL_RANGE(5,14,0,503,21,1, 5,15,0,0,0,0))
> +
> LTTNG_TRACEPOINT_EVENT_CLASS(asoc_snd_soc_dapm_basic,
>
> TP_PROTO(struct snd_soc_card *card, int event),
> diff --git a/include/instrumentation/events/skb.h b/include/instrumentation/events/skb.h
> index 5556ab6..becfd80 100644
> --- a/include/instrumentation/events/skb.h
> +++ b/include/instrumentation/events/skb.h
> @@ -40,7 +40,9 @@ LTTNG_TRACEPOINT_ENUM(skb_drop_reason,
> )
> #endif
>
> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,11,0))
> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,11,0) || \
> + LTTNG_RHEL_KERNEL_RANGE(5,14,0,503,21,1, 5,15,0,0,0,0))
> +
> LTTNG_TRACEPOINT_EVENT_MAP(kfree_skb,
>
> skb_kfree,
> diff --git a/include/instrumentation/events/udp.h b/include/instrumentation/events/udp.h
> index 0a94b46..c228ef6 100644
> --- a/include/instrumentation/events/udp.h
> +++ b/include/instrumentation/events/udp.h
> @@ -9,7 +9,9 @@
> #include <linux/udp.h>
> #include <lttng/kernel-version.h>
>
> -#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,10,0))
> +#if (LTTNG_LINUX_VERSION_CODE >= LTTNG_KERNEL_VERSION(6,10,0) || \
> + LTTNG_RHEL_KERNEL_RANGE(5,14,0,503,21,1, 5,15,0,0,0,0))
> +
> LTTNG_TRACEPOINT_ENUM(lttng_sk_family,
> TP_ENUM_VALUES(
> ctf_enum_value("AF_INET", AF_INET)
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2025-01-21 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 14:23 Martin Hicks via lttng-dev
2025-01-21 19:56 ` Mathieu Desnoyers via lttng-dev [this message]
2025-01-22 13:08 ` Martin Hicks via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7127ac1b-7cc5-4f98-afe8-1244c3a5056b@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=martin@sr-research.com \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox