From mboxrd@z Thu Jan  1 00:00:00 1970
From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Date: Wed, 27 Nov 2013 09:34:13 +0000 (UTC)
Subject: [lttng-dev] [PATCH liburcu 4/5] Fix: Do not redefine gettid on
	Android
In-Reply-To: <1385528902-4797-4-git-send-email-charlesbriere.flatzo@gmail.com>
References: <1385528902-4797-1-git-send-email-charlesbriere.flatzo@gmail.com>
	<1385528902-4797-4-git-send-email-charlesbriere.flatzo@gmail.com>
Message-ID: <619278900.76525.1385544853544.JavaMail.zimbra@efficios.com>

----- Original Message -----
> From: "Charles Briere" <charlesbriere.flatzo@gmail.com>
> To: "mathieu desnoyers" <mathieu.desnoyers at efficios.com>
> Cc: lttng-dev at lists.lttng.org, "Charles Briere" <charlesbriere.flatzo at gmail.com>
> Sent: Wednesday, November 27, 2013 12:08:21 AM
> Subject: [PATCH liburcu 4/5] Fix: Do not redefine gettid on Android
> 
> Bionic already defines gettid through <unistd.h>
> 
> Signed-off-by: Charles Briere <charlesbriere.flatzo at gmail.com>
> ---
>  tests/common/thread-id.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/common/thread-id.h b/tests/common/thread-id.h
> index bad3006..a2c9e3a 100644
> --- a/tests/common/thread-id.h
> +++ b/tests/common/thread-id.h
> @@ -42,6 +42,9 @@ unsigned long urcu_get_thread_id(void)
>  {
>  	return (unsigned long) pthread_getthreadid_np();
>  }
> +#elif defined(__Android__)
> +// Do not redefine gettid() as it is already included
> +// in bionic through <unistd.h>

Please use

/*
 * blah
 * blah blah
 */

style comments,

Thanks,

Mathieu

>  #else
>  # warning "use pid as thread ID"
>  static inline
> --
> 1.8.4.2
> 
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com