From: nils.carlson@ludd.ltu.se (Nils Carlson)
Subject: [ltt-dev] [UST PATCH] Correct error handling and add error message in ustcmd.c
Date: Sat, 11 Sep 2010 20:35:08 +0200 [thread overview]
Message-ID: <5BBA9820-A2AF-4ED9-9A5D-8D469F784D10@ludd.ltu.se> (raw)
In-Reply-To: <4C8BA7EC.6020502@polymtl.ca>
Ah,
Sorry, missed that one. Need to start sorting e-mails better on
subject line... Sorry douglas.
Strike mine, I'll comment douglas'.
/Nils
On Sep 11, 2010, at 6:01 PM, David Goulet wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I thought so!
>
> This is the Douglas Santos patch ;)
>
> This is why I told you to Ack and then start the discussion in two
> seperate
> emails :P:P
>
> Cheers
> David
>
> On 10-09-11 11:00 AM, Mathieu Desnoyers wrote:
>> * Nils Carlson (nils.carlson at ericsson.com) wrote:
>>>
>>> Signed-off-by: Nils Carlson <nils.carlson at ericsson.com>
>>
>> David, Nils, please double-check that you are not fixing the same
>> problem twice with slightly different patches. I think I've seen this
>> one recently.
>>
>> Thanks,
>>
>> Mathieu
>>
>>
>>> ---
>>> libustcmd/ustcmd.c | 5 +----
>>> 1 files changed, 1 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/libustcmd/ustcmd.c b/libustcmd/ustcmd.c
>>> index 4248072..c512320 100644
>>> --- a/libustcmd/ustcmd.c
>>> +++ b/libustcmd/ustcmd.c
>>> @@ -396,10 +396,6 @@ int ustcmd_get_cmsf(struct marker_status
>>> **cmsf, const pid_t pid)
>>> }
>>> result = ustcmd_send_cmd("list_markers", pid, &big_str);
>>> if (result != 1) {
>>> - return -1;
>>> - }
>>> -
>>> - if (result != 1) {
>>> ERR("error while getting markers list");
>>> return -1;
>>> }
>>> @@ -407,6 +403,7 @@ int ustcmd_get_cmsf(struct marker_status
>>> **cmsf, const pid_t pid)
>>> tmp_cmsf = (struct marker_status *) malloc(sizeof(struct
>>> marker_status) *
>>> (ustcmd_count_nl(big_str) + 1));
>>> if (tmp_cmsf == NULL) {
>>> + ERR("Failed to allocate CMSF array");
>>> return -1;
>>> }
>>>
>>> --
>>> 1.7.1
>>>
>>>
>>> _______________________________________________
>>> ltt-dev mailing list
>>> ltt-dev at lists.casi.polymtl.ca
>>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>>
>>
>
> - --
> David Goulet
> LTTng project, DORSAL Lab.
>
> 1024D/16BD8563
> BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAkyLp+wACgkQSvfBSxa9hWMDEwCgq6hMc6phDxw6J1kMTavtocSG
> sEkAn3LeMeIrMVKSQH5STkiIOAiSQb0h
> =V3Im
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
next prev parent reply other threads:[~2010-09-11 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 11:30 Nils Carlson
2010-09-11 15:00 ` Mathieu Desnoyers
2010-09-11 16:01 ` David Goulet
2010-09-11 18:35 ` Nils Carlson [this message]
2010-09-11 18:48 ` Douglas Santos
2010-09-13 12:33 ` Nils Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BBA9820-A2AF-4ED9-9A5D-8D469F784D10@ludd.ltu.se \
--to=nils.carlson@ludd.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox