Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: laijs@cn.fujitsu.com (Lai Jiangshan)
Subject: [lttng-dev] [RFC] re-document rculfstack and even rename it
Date: Wed, 10 Oct 2012 15:52:08 +0800	[thread overview]
Message-ID: <50752928.3050006@cn.fujitsu.com> (raw)

rculfstack is not really require RCU-only.

1) cds_lfs_push_rcu() don't need any lock, don't need RCU nor other locks.

2) cds_lfs_pop_rcu() don't only one of the following synchronization(not only RCU):
	A) use rcu_read_lock() to protect cds_lfs_pop_rcu() and use synchronize_rcu()
           or call_rcu() to free the popped node. (current comments said we need this
           synchronization, and thus we named this struct with rcu prefix. But actually,
	   the followings are OK, and are more popular/friendly)
	B) use mutexs/locks to protect cds_lfs_pop_rcu(), we can free to free/modify the
	   popped node any time, we don't need any synchronization when free them.
	C) only ONE thread can call cds_lfs_pop_rcu(). (multi-providers-single customer)
	D) others, like read-write locks.

I consider B) and C) are more popular. In linux kernel,
kernel/task_work.c uses a hybird ways of B) and C).

I suggest to rename it, Or document B) and C) at least.

Thanks,
Lai



             reply	other threads:[~2012-10-10  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10  7:52 Lai Jiangshan [this message]
2012-10-10 14:59 ` Paul E. McKenney
2012-10-11 18:22 ` Mathieu Desnoyers
2012-10-12  2:25   ` Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50752928.3050006@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox