Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: matthew.khouzam@ericsson.com (Matthew Khouzam)
Subject: [ltt-dev] [RFC] UST Tracepoint API Changes
Date: Fri, 4 Nov 2011 12:56:46 -0400	[thread overview]
Message-ID: <4EB4194E.9080700@ericsson.com> (raw)
In-Reply-To: <20111102140027.GA29033@Krystal>



On 11-11-02 10:00 AM, Mathieu Desnoyers wrote:
> Hi,
>
> Following discussions at LinuxCon, there are two changes I would like to
> propose for the TRACEPOINT_EVENT API. Comments are welcome:
>
> 1) Change the first argument of TRACEPOINT_EVENT, defined as:
>
>   < [com_company_]project_[component_]event >
>
>   for two arguments, separated by a comma:
>
>   < [com_company_]project[_component] >, < event >
>
> This would be more in line with the Dtrace "provider, event" scheme,
> which is already very much in use for instrumentation. This would allow
> application developers to make the mapping to dtrace instrumentation
> they might already have more easiy.
Basically to illustrate that:
TRACEPOINT_EVENT( com_efficios_babeltrace_reader_openfile, ... )
becomes
TRACEPOINT_EVENT( com_efficios_babeltrace_reader, openfile, ... )
I like it, it's not overly complex and forces people to better think out
their tracepoint names.
>
> 2) Not sure about the following one: TRACEPOINT_EVENT is quite long to
> type in, and so it "tracepoint()", and the upcoming
> "tracepoint_printf()". I'm thinking about going for shorter names, but I
> also want to try not to get conflicts with existing code out there.
> Ideas on a shorter yet explanatory name would be very welcome.
>
> tp_* seems a little bit short and prone to conflicts.
sounds like toilet paper, and it is used a lot with other projects.
> tracep_ sounds too much like ptrace.
also, the p is ambiguous, why not just trace_ at that point?
> tracept_ might be good enough. It's only downside might be to sound like
> "trace-pity" when we say it out loud. ;-)
pt is the unsaid shorthand for point. it would be easily understood by
most IMO. but at this point you are three letters away from tracepoint_
I would suggest going full length and letting those who don't like
typing either the option to use a code completing IDE like eclipse-cdt,
or making macros that make sense to them.
>
> Thanks,
>
> Mathieu
>




  reply	other threads:[~2011-11-04 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 14:00 Mathieu Desnoyers
2011-11-04 16:56 ` Matthew Khouzam [this message]
2011-11-04 19:31   ` Mathieu Desnoyers
2011-11-05 12:16   ` Mathieu Desnoyers
2011-11-07 21:53     ` Matthew Khouzam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB4194E.9080700@ericsson.com \
    --to=matthew.khouzam@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox