Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: david.goulet@polymtl.ca (David Goulet)
Subject: [ltt-dev] [UST PATCH] Fix bug in test_functions.sh
Date: Tue, 21 Sep 2010 09:02:27 -0400	[thread overview]
Message-ID: <4C98ACE3.6050309@polymtl.ca> (raw)
In-Reply-To: <1285070044-5376-1-git-send-email-nils.carlson@ericsson.com>

Hey Nils,

I don't understand here why you need to specify OPTIND as local. Isn't a 
global variable set by getops only used in the while loop..

Thanks
David

On 10-09-21 07:54 AM, Nils Carlson wrote:
> As we were playing with OPTIND we managed to match the same
> thing multiple times. Maybe make this more elegant in the
> future.
>
> Signed-off-by: Nils Carlson<nils.carlson at ericsson.com>
> ---
>   tests/test_functions.sh |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tests/test_functions.sh b/tests/test_functions.sh
> index d27a734..40d4d89 100644
> --- a/tests/test_functions.sh
> +++ b/tests/test_functions.sh
> @@ -40,6 +40,7 @@ function check_trace_logs() {
>
>
>   function trace_matches() {
> +    local OPTIND=
>
>       RUNLTTV=~/devel/lttv/runlttv
>

-- 
David Goulet
LTTng project, DORSAL Lab.

PGP/GPG : 1024D/16BD8563
BE3C 672B 9331 9796 291A  14C6 4AF7 C14B 16BD 8563




  reply	other threads:[~2010-09-21 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 11:54 Nils Carlson
2010-09-21 13:02 ` David Goulet [this message]
2010-09-21 16:18   ` Nils Carlson
2010-09-22  6:58     ` Nils Carlson
2010-09-22 14:09       ` David Goulet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C98ACE3.6050309@polymtl.ca \
    --to=david.goulet@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox