Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: pbonzini@redhat.com (Paolo Bonzini)
Subject: [ltt-dev] [PATCH RFC] Force build failure on unknown architectures
Date: Wed, 16 Jun 2010 14:23:18 +0200	[thread overview]
Message-ID: <4C18C236.3030100@redhat.com> (raw)
In-Reply-To: <20100616001228.GM2304@linux.vnet.ibm.com>

On 06/16/2010 02:12 AM, Paul E. McKenney wrote:
> On Wed, Jun 16, 2010 at 01:55:13AM +0200, Paolo Bonzini wrote:
>> On 06/16/2010 01:14 AM, Paul E. McKenney wrote:
>>> Create urcu/arch_unknown.h and urcu/uatomic_arch_unknown.h, which
>>> contain only #error statements and explanatory comments.  This forces
>>> build failures on unrecognized architectures in preference to trying
>>> to guess at what operations might be safe on such architectures.
>>>
>>> One other semi-feasible alternative is to use hashed arrays of locks
>>> that are acquired with signals disabled.  However, this seems a bit
>>> too ornate, especially for architectures for which the gcc __sync_
>>> primitives work correctly.
>>
>> ia64 is one.
>
> Does ia64 work with the current code?  (My guess is "no" -- I believe
> that you would get build errors.  But I have been surprised before!)

I don't know. :)

> If my guess is correct, my thought would be to create urcu/arch_gcc.h
> and urcu/uatomic_arch_gcc.h files with the appropriate definitions
> based on __sync_ primitives.  If you can test on IA64, I would also
> be happy to add support for it based on these new files.

Sure, thanks!

Paolo




  reply	other threads:[~2010-06-16 12:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 23:14 Paul E. McKenney
2010-06-15 23:55 ` Paolo Bonzini
2010-06-16  0:12   ` Paul E. McKenney
2010-06-16 12:23     ` Paolo Bonzini [this message]
2010-06-16 13:46       ` Mathieu Desnoyers
2010-06-16 15:53         ` Paul E. McKenney
2010-06-16 15:53       ` Paul E. McKenney
2010-06-16 16:40         ` Paolo Bonzini
2010-06-16 21:10           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C18C236.3030100@redhat.com \
    --to=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox