From mboxrd@z Thu Jan  1 00:00:00 1970
From: pbonzini@redhat.com (Paolo Bonzini)
Date: Mon, 15 Feb 2010 08:53:34 +0100
Subject: [ltt-dev] [PATCH 03/11] add urcu/arch_defaults.h
In-Reply-To: <20100214143459.GD5871@Krystal>
References: <1266081392-8732-1-git-send-email-pbonzini@redhat.com>
	<1266081392-8732-4-git-send-email-pbonzini@redhat.com>
	<20100214143459.GD5871@Krystal>
Message-ID: <4B78FD7E.8050402@redhat.com>

On 02/14/2010 03:34 PM, Mathieu Desnoyers wrote:
> +#if !defined(mc)&&  !defined(rmc)&&  !defined(wmc)
>
> instead ?

Ok.

>> >  +/*
>> >  + * Architectures without cache coherency need something like the following:
>> >  + *
>> >  + * #define mb()	mc()
>> >  + * #define rmb()	rmc()
>> >  + * #define wmb()	wmc()
>> >  + * #define mc()	arch_cache_flush()        // mandatory
>
> The // comment style should be avoided. (Following Linux kernel
> guide-lines)

Note that this is within a comment; I used it reluctantly because C 
comments do not nest.  I could replace it with "<-- mandatory" but I 
think // is better in this case.

Paolo