From mboxrd@z Thu Jan  1 00:00:00 1970
From: matthieu.castet@parrot.com (Matthieu CASTET)
Date: Thu, 13 Aug 2009 17:57:16 +0200
Subject: [ltt-dev] Tracing thread name
In-Reply-To: <4A784056.1020400@parrot.com>
References: <4A76E42D.7010908@parrot.com>
	<20090803134843.GB23455@Krystal>	<4A78099B.4@parrot.com>
	<20090804130510.GA23396@Krystal> <4A784056.1020400@parrot.com>
Message-ID: <4A8437DC.8080509@parrot.com>

Matthieu CASTET a ?crit :
> Hi,
> 
> Mathieu Desnoyers a ?crit :
>> * Matthieu CASTET (matthieu.castet at parrot.com) wrote:
>>> Hi Mathieu,
>>>
>>> Mathieu Desnoyers a ?crit :
>>> Do you know if it is possible to patch my version to add such feature ?
>>>
>>> I saw that the name already change in the trace before/after an exec.
>>> How lltv get the new name ?
>>> With "fs.exec" tracepoint ?
>>> In that case I could fake a "fs.exec" tracepoint in set_task_comm.
>> A better solution : you add a new event in both lttng and lttv, and
>> modify state.c to support your new event. The current event to brand
>> thread is named "userspace.thread_brand". Look for this in LTTV to see
>> all the sites that need to support the new event (there are very few).
>>
> Thanks, but I want to avoid to modify too much ltt (I use an old version
> for 2.6.27 and my modifications may be useless for upstream).
> 
> I added "trace_fs_exec(tsk->comm);" at the end of set_task_comm and now
> the thread got the correct name :)
> 
BTW it is also interesting to get the name of the kernel threads
(created by kthread_create).
The current version of ltt show "kthreadd" for these threads.

The same solution than set_task_comm should solve the problem (comm is
set at the end of kthread_create).


Matthieu

PS: khelper thread are also annoying because they all got the same name.
May be it could be interesting to add extra info in the name.