[ltt-dev] [PATCH] LTTng: Make mark-control work in debugfs

[guijianfeng@cn.fujitsu.com (Gui Jianfeng)]

KOSAKI Motohiro wrote:
>>   Hi Mathieu,
>>
>>   I guess it's not easy to implement the *mkdir* for marker control.
>>   But I have an alternative solution that we can add a control file
>>   *new_channel* at the same level of channel directories, and add a 
>>   control file *new_marker* in each channel directory.
>>   Making use of the following, we can create a marker even if it 
>>   doesn't exist by now.
>>
>>   cd /mnt/ltt/markers
>>   echo "channel_name" > new_channel
>>   echo "marker_name" > channel_name/new_marker
> 
> No.
> good user interface is important than easy implementation.
> 
> this UI is really ugly.

  Hi Kosaki-san,

  Thank you for your kind comments.
  I say *not easy* becasue debugfs itself doesn't support *mkdir* completely.
  If we are going to implement mkdir in marker control, we have to modify debugfs
  itself. IMHO, it's not reasonable and i guess most of the debugfs subsystems don't 
  like to see this change.
  On the other hand, it's very natual to use a control file to do something in debugfs.
  So, I choose this solution. I hope that what I say will clarify the situation.:)
  Mathieu, What do you say?


> 
> 
> 
> 
> 
> 

-- 
Regards
Gui Jianfeng