From mboxrd@z Thu Jan  1 00:00:00 1970
From: dwt@PolTec.COM (Dennis W. Tokarski)
Date: Mon, 19 Jan 2009 13:40:51 -0500
Subject: [ltt-dev] too few arguments to function 'ltt_vtrace'
Message-ID: <4974C933.8040408@PolTec.COM>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Matthieu,

I've just tried to build a kernel based on Fedora's
kernel-2.6.27.9-150.fc10.src.rpm. Your patch set from
patch-2.6.27.9-lttng-0.70.tar.bz2 applied with minimal
conflicts which were easily resolved.

However the error message in the subject above occurs
during build.

In ltt_serialize.c, ltt_vtrace() is defined as requiring
five arguments, while in ltt-ftrace.c ltt_tap_marker()
calls it with four--you aren't providing the required
pointer to a struct marker as the first arg. It's not
at all clear from the surrounding code what ltt_tap_marker()
*should* be passing, but ltt_vtrace() certainly wants to
use the arg.

Same deal with is_marker_enabled() in kernel/marker.c,
you call it from markers_show() in fs/proc/base.c without
the first arg.

A quick look at your web repository shows the second
bug fixed, but the first is still present in the
head revision.

So how do you get a kernel to build at all, much less
run and actually take a trace?  What actual revisions
are you using for your work?

I'd really like to give lttng a try, but there is
this little show-stopper.

Thanks for your help!
- --Dennis

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFJdMkrDJucIzCImrURAg/SAJ98BwoJPl1gfOWVZJI8b90o6zS5UQCdGLz/
9JN1AdEXEQkNn89HBpLykeY=
=c3cJ
-----END PGP SIGNATURE-----