From mboxrd@z Thu Jan  1 00:00:00 1970
From: zhaolei@cn.fujitsu.com (Zhaolei)
Date: Thu, 18 Dec 2008 13:38:11 +0800
Subject: [ltt-dev] [PATCH 2/1] tracepoints-panic
In-Reply-To: <20081218041402.GA21563@Krystal>
References: <4949BD17.2000704@cn.fujitsu.com> <4949BD46.3020806@cn.fujitsu.com>
	<20081218041402.GA21563@Krystal>
Message-ID: <4949E1C3.7000308@cn.fujitsu.com>

Mathieu Desnoyers wrote:
> * Zhaolei (zhaolei at cn.fujitsu.com) wrote:
>> Instrumentation of panic related events : now include panic event only.
>> It is useful for build flight-recorder program based on lttng infrastructure.
>>
>> Signed-off-by: Zhao lei <zhaolei at cn.fujitsu.com>
>> ---
>>  include/trace/panic.h |   10 ++++++++++
>>  kernel/panic.c        |    7 +++++++
>>  2 files changed, 17 insertions(+), 0 deletions(-)
>>  create mode 100644 include/trace/panic.h
>>
>> diff --git a/include/trace/panic.h b/include/trace/panic.h
>> new file mode 100644
>> index 0000000..eede4ca
>> --- /dev/null
>> +++ b/include/trace/panic.h
>> @@ -0,0 +1,10 @@
>> +#ifndef _TRACE_PANIC_H
>> +#define _TRACE_PANIC_H
>> +
>> +#include <linux/tracepoint.h>
>> +
>> +DECLARE_TRACE(panic_panic,
>> +	TPPROTO(const char *fmt, va_list args),
>> +	TPARGS(fmt, args));
>> +
> 
> Interesting idea. Maybe kernel_panic would be more appropriate, in
> include/trace/kernel.h ?
Hello, Mathieu

Thanks for your advise.
I will send v2 of this patch.

B.R
Zhaolei
> 
> Mathieu
> 
>> +#endif
>> diff --git a/kernel/panic.c b/kernel/panic.c
>> index 12c5a0a..33b4440 100644
>> --- a/kernel/panic.c
>> +++ b/kernel/panic.c
>> @@ -21,6 +21,9 @@
>>  #include <linux/debug_locks.h>
>>  #include <linux/random.h>
>>  #include <linux/kallsyms.h>
>> +#include <trace/panic.h>
>> +
>> +DEFINE_TRACE(panic_panic);
>>  
>>  int panic_on_oops;
>>  int tainted;
>> @@ -68,6 +71,10 @@ NORET_TYPE void panic(const char * fmt, ...)
>>  	unsigned long caller = (unsigned long) __builtin_return_address(0);
>>  #endif
>>  
>> +	va_start(args, fmt);
>> +	trace_panic_panic(fmt, args);
>> +	va_end(args);
>> +
>>  	/*
>>  	 * It's possible to come here directly from a panic-assertion and not
>>  	 * have preempt disabled. Some functions called from here want
>> -- 
>> 1.5.5.3
>>
>>
>