Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: zhaolei@cn.fujitsu.com (Zhaolei)
Subject: [ltt-dev] [PATCH] make lttctl select channel_root in debugfs automatically
Date: Thu, 16 Oct 2008 12:08:50 +0800	[thread overview]
Message-ID: <48F6BE52.1080202@cn.fujitsu.com> (raw)

Hi Mathieu,

this patch make lttctl select channel_root in debugfs automatically
 when no specify.
Applies on top of ltt-control-0.54-10102008.

Signed-off-by: Zhaolei <zhaolei at cn.fujitsu.com>
---
diff -Nur ltt-control-0.54-10102008.org/lttctl/lttctl.c ltt-control-0.54-10102008/lttctl/lttctl.c
--- ltt-control-0.54-10102008.org/lttctl/lttctl.c	2008-10-15 15:29:54.000000000 +0800
+++ ltt-control-0.54-10102008/lttctl/lttctl.c	2008-10-16 11:53:49.000000000 +0800
@@ -22,6 +22,7 @@
 #include <signal.h>
 #include <dirent.h>
 #include <string.h>
+#include <limits.h>
 #include <sys/stat.h>
 
 /* Buffer for file copy : 4k seems optimal. */
@@ -52,6 +53,7 @@
 static enum trace_mode mode = LTT_TRACE_NORMAL;
 static enum trace_ctl_op op = CTL_OP_NONE;
 static char *channel_root = NULL;
+static char channel_root_default[PATH_MAX];
 static char *trace_root = NULL;
 static char *num_threads = "1";
 
@@ -92,6 +94,26 @@
 	printf("\n");
 }
 
+int getdebugfsmntdir(char *mntdir)
+{
+	char mnt_dir[PATH_MAX];
+	char mnt_type[PATH_MAX];
+
+	FILE *fp = fopen("/proc/mounts", "r");
+	if (!fp) {
+		return EINVAL;
+	}
+
+	while (1) {
+		if (fscanf(fp, "%*s %s %s %*s %*s %*s", mnt_dir, mnt_type) <= 0) {
+			return ENOENT;
+		}
+		if (!strcmp(mnt_type, "debugfs")) {
+			strcpy(mntdir, mnt_dir);
+			return 0;
+		}
+	}
+}
 
 /* parse_arguments
  *
@@ -304,9 +326,16 @@
 			ret = EINVAL;
 		}
 		if(channel_root == NULL) {
-			printf("Please specify -l ltt_root_path with the -d option.\n");
-			printf("\n");
-			ret = EINVAL;
+			if (getdebugfsmntdir(channel_root_default) == 0) {
+				strcat(channel_root_default, "/ltt");
+				printf("No -l ltt_root_path with the -d option, using default: %s\n", channel_root_default);
+				printf("\n");
+				channel_root=channel_root_default;
+			} else {
+				printf("Please specify -l ltt_root_path with the -d option.\n");
+				printf("\n");
+				ret = EINVAL;
+			}
 		}
 	}
 





             reply	other threads:[~2008-10-16  4:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16  4:08 Zhaolei [this message]
2008-10-16  7:46 ` [ltt-dev] [PATCH] Make ltt_trace_start return error when trace_name not exist Zhaolei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48F6BE52.1080202@cn.fujitsu.com \
    --to=zhaolei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox