From mboxrd@z Thu Jan 1 00:00:00 1970 From: nils.carlson@ludd.ltu.se (Nils Carlson) Date: Tue, 9 Nov 2010 19:01:12 +0100 Subject: [ltt-dev] [UST PATCH] Include trace name in output directory name In-Reply-To: <4CD978DB.8090503@polymtl.ca> References: <1289230479-26815-1-git-send-email-nils.carlson@ericsson.com> <4CD978DB.8090503@polymtl.ca> Message-ID: <418DA4DE-D011-4DA5-84D3-E8BDDA090E59@ludd.ltu.se> On Nov 9, 2010, at 5:37 PM, David Goulet wrote: > How about we put the trace name in front and don't have the PID as > the first value and STOP having multiple traces beginning with > numbers that make things quite confusing in a long term and painful > to identify the good trace ? > Yep, maybe it's best to really do something about the order... What about doing date prefixing followed by the trace name and if necessary followed by a seq nr? Something like 20101109-152301-auto 20101109-152301-auto_1 (in case of collision?) We might also consider putting the actual application name (the first stripped token of argv[0] in there? /Nils > David > > On 10-11-08 10:34 AM, Nils Carlson wrote: >> Include the name of the trace to the output directory created by >> ustd. Yet another part of multi-session support. >> >> Signed-off-by: Nils Carlson >> --- >> ustd/ustd.c | 12 ++++++------ >> 1 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/ustd/ustd.c b/ustd/ustd.c >> index e75fd9d..3f63457 100644 >> --- a/ustd/ustd.c >> +++ b/ustd/ustd.c >> @@ -191,9 +191,9 @@ int on_open_buffer(struct libustd_callbacks >> *data, struct buffer_info *buf) >> trace_path = USTD_DEFAULT_TRACE_PATH; >> } >> >> - if (asprintf(&tmp, "%s/%u_%lld", trace_path, buf->pid, buf- >> >pidunique)< 0) { >> - ERR("on_open_buffer : asprintf failed (%s/%u_%lld)", >> - trace_path, buf->pid, buf->pidunique); >> + if (asprintf(&tmp, "%s/%u_%s_%lld", trace_path, buf->pid, buf- >> >trace, buf->pidunique)< 0) { >> + ERR("on_open_buffer : asprintf failed (%s/%u_%s_%lld)", >> + trace_path, buf->pid, buf->trace, buf->pidunique); >> return 1; >> } >> result = create_dir_if_needed(tmp); >> @@ -204,9 +204,9 @@ int on_open_buffer(struct libustd_callbacks >> *data, struct buffer_info *buf) >> } >> free(tmp); >> >> - if (asprintf(&tmp, "%s/%u_%lld/%s", trace_path, buf->pid, buf- >> >pidunique, buf->name)< 0) { >> - ERR("on_open_buffer : asprintf failed (%s/%u_%lld/%s)", >> - trace_path, buf->pid, buf->pidunique, buf->name); >> + if (asprintf(&tmp, "%s/%u_%s_%lld/%s", trace_path, buf->pid, buf- >> >trace, buf->pidunique, buf->name)< 0) { >> + ERR("on_open_buffer : asprintf failed (%s/%u_%s_%lld/%s)", >> + trace_path, buf->pid, buf->trace, buf->pidunique, buf->name); >> return 1; >> } >> result = fd = open(tmp, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, >> 00600); > > -- > David Goulet > LTTng project, DORSAL Lab. > > PGP/GPG : 1024D/16BD8563 > BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563 > > _______________________________________________ > ltt-dev mailing list > ltt-dev at lists.casi.polymtl.ca > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev