From mboxrd@z Thu Jan  1 00:00:00 1970
From: nils.carlson@ludd.ltu.se (Nils Carlson)
Date: Thu, 30 Sep 2010 21:21:08 +0200
Subject: [ltt-dev] [UST] malloc error found by david
In-Reply-To: <4CA3C561.3060807@polymtl.ca>
References: <20100929132755.GA20790@starquasia> <20100929150622.GA6625@Krystal>
	<5F47D9E1-3BBB-4016-921E-22804AB46220@ludd.ltu.se>
	<20100929204016.GA24400@Krystal> <4CA3C561.3060807@polymtl.ca>
Message-ID: <3E62D12A-B4E9-4C14-8001-55A7E39E651E@ludd.ltu.se>


On Sep 30, 2010, at 1:01 AM, David Goulet wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
>
> On 10-09-29 04:40 PM, Mathieu Desnoyers wrote:
>> Hi Nils,
>>
>> Please double-check that you ported commit
>>
>> 38516ab59fbc5b3bb278cf5e1fe2867c70cff32e
>>
>>    tracing: Let tracepoints have data passed to tracepoint callbacks
>>
>> correctly from mainline. There is at least a bug in
>>
>> static inline void *allocate_probes(int count)
>>
>> (sizeof(void *) should be changed for sizeof(struct tracepoint_func))
>
> Yes, but for UST, it's sizeof(struct probe), actually almost the  
> same but
> different name :P
>
> This was introduce in UST from commit (in libust/tracepoint.c)
> 	
> 1dba3e6c054da18f238d051da5b1839bd5e4e4dd
>
> I really have NO idea how it came in because for that commit I only  
> changed the
> malloc to zmalloc. So I think, somekind of "merge" between patches  
> went wrong
> and git didn't notice. Shit happens ;)
>

Yepp. Applied fix, haven't done any digging in how it got in there.

/Nils

> Thanks
> David
>
>>
>> Hopefully no other bugs crept in.
>>
>> Credits go to David Goulet, how just spent 2 days hunting this one  
>> down.
>>
>> Thanks,
>>
>> Mathieu
>>
>>
>>
>
> - --
> David Goulet
> LTTng project, DORSAL Lab.
>
> 1024D/16BD8563
> BE3C 672B 9331 9796 291A  14C6 4AF7 C14B 16BD 8563
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iEYEARECAAYFAkyjxWEACgkQSvfBSxa9hWPcUQCePVOAXil4Qi5L53XPY5sx1yH3
> U+AAoLqnA+GDQz1BM3Cp6c1rMMgq+Lcp
> =Uken
> -----END PGP SIGNATURE-----