[lttng-dev] [PATCH] [RESUBMISSION] lttng-tools lib/lttng-ctl/lttng-ctl.c : Document return values and more

[Daniel.Thibault@drdc-rddc.gc.ca (Thibault, Daniel)]

-----Message d'origine-----
De?: David Goulet [mailto:david.goulet at polymtl.ca] 
Envoy??: 30 janvier 2012 13:12

> I'm having problem applying those patches. It fails at the third one and I think
> it's because you change lttng-ctl.c in the second patch and the third one is not
> based on those changes.

   But it is!?

> Can you please send me three separate emails for those patches (one per mail)
> and had your "Signed-off-by" also (just add "-s" to git commit, it will do it
> automatically for you). It helps me a lot for review and merge.

   Er...I don't seem to have the option of adding "-s", 'cause I'm using EGit from Eclipse.  The only options I get when producing a patch are a) output to clipboard or file, b) export in git patch format or not, and c) the number of lines of context.  Never mind, found it in Window: Preferences: Team: Git: Commit dialog.

   Now, out here we have a separate problem getting at the git repositories using the git: protocol.  The port isn't open in out firewall.  A request has been submitted to get that opened.  Meantime, I must download a local copy of the git commits and import them as regular projects before "gitifying" them.  Bottom line: it works but there are extra hoops to jump through for now.  Once our firewall problem is solved, it'll be a lot easier for me to follow the code's evolution.

   So, in order to fix the problem you're having with the "third patch" ([PATCH] lttng-tools lib/lttng-ctl/lttng-ctl.c : Various code fixes), I'll download the current version (I see I'm 15 commits behind) and regenerate patches from there.

Daniel U. Thibault
R & D pour la d?fense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier)
Syst?me de syst?mes (SdS) / System of Systems (SoS)
Solutions informatiques et exp?rimentations (SIE) / Computing Solutions and Experimentations (CSE)
2459 Boul. Pie XI Nord
Qu?bec, QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC: 918V QSDJ
Gouvernement du Canada / Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>