From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel.Thibault@drdc-rddc.gc.ca (Thibault, Daniel) Date: Fri, 23 Sep 2011 15:58:08 -0400 Subject: [ltt-dev] Getting writeTraceNetwork to work In-Reply-To: <3CA1A65C03C1A34C81BBC6272782E696719119@valcartierex01.valcartier.drdc-rddc.gc.ca> References: <3CA1A65C03C1A34C81BBC6272782E6967190AB@valcartierex01.valcartier.drdc-rddc.gc.ca> <3CA1A65C03C1A34C81BBC6272782E6967190B2@valcartierex01.valcartier.drdc-rddc.gc.ca> <3CA1A65C03C1A34C81BBC6272782E696719119@valcartierex01.valcartier.drdc-rddc.gc.ca> Message-ID: <3CA1A65C03C1A34C81BBC6272782E6967535AA@valcartierex01.valcartier.drdc-rddc.gc.ca> Back in May I asked about writeTraceNetwork, which stubbornly and ungracefully refused to work, raising an exception fatal for the tcf client. I've tracked the problem down to invocations of flush_stream, which has been withdrawn from the code base for a long time now. The last implementation seen in streams.c actually assigned an empty function to flush_stream, so it never actually did anything. Between versions 72ea7d0 (2011-Mar-23) and 7a8767c (2011-Aug-12) of lttng-agent, some of the errant calls to flush_stream have been deleted, but some still remain. They must also be deleted in order to get writeTraceNetwork to work. The two small diffs I propose follow: ############################## lttctlustlibustdcallbacks.c ############################## --- a/agent/lttctlustlibustdcallbacks.c 2011-08-12 11:02:15.000000000 -0400 +++ b/agent/lttctlustlibustdcallbacks.c 2011-09-22 16:51:06.000000000 -0400 @@ -85,7 +85,7 @@ write_stream(out, 0); write_stream(out, MARKER_EOM); - flush_stream(out); +// flush_stream(out); pthread_barrier_wait(tcf_data->barrier); } ############################## lttctlclient.c ############################## --- a/client/lttctlclient.c 2011-08-12 11:02:15.000000000 -0400 +++ b/client/lttctlclient.c 2011-09-22 17:10:40.000000000 -0400 @@ -480,9 +480,9 @@ write_stringz(&c->out, args[i]); } write_stream(&c->out, MARKER_EOM); - flush_stream(&c->out); +// flush_stream(&c->out); /* fprintf(stderr, "lttctlclient : Just sent a cmd!\n"); */ ############################## (end) ############################## Daniel U. Thibault R & D pour la d?fense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier) Syst?me de syst?mes (SdS) / System of Systems (SoS) Solutions informatiques et exp?rimentations (SIE) / Computing Solutions and Experimentations (CSE) 2459 Boul. Pie XI Nord Qu?bec, QC G3J 1X5 CANADA Vox : (418) 844-4000 x4245 Fax : (418) 844-4538 NAC: 918V QSDJ Gouvernement du Canada / Government of Canada > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel.Thibault@drdc-rddc.gc.ca (Thibault, Daniel) Date: Fri, 23 Sep 2011 15:58:08 -0400 Subject: [ltt-dev] Getting writeTraceNetwork to work In-Reply-To: <3CA1A65C03C1A34C81BBC6272782E696719119@valcartierex01.valcartier.drdc-rddc.gc.ca> References: <3CA1A65C03C1A34C81BBC6272782E6967190AB@valcartierex01.valcartier.drdc-rddc.gc.ca> <3CA1A65C03C1A34C81BBC6272782E6967190B2@valcartierex01.valcartier.drdc-rddc.gc.ca> <3CA1A65C03C1A34C81BBC6272782E696719119@valcartierex01.valcartier.drdc-rddc.gc.ca> Message-ID: <3CA1A65C03C1A34C81BBC6272782E6967535AA@valcartierex01.valcartier.drdc-rddc.gc.ca> Message-ID: <20110923195808.Ae5fHDjkXMr30PeY0638ojdj-Spsw8BPs6iX7MV7BU0@z> Back in May I asked about writeTraceNetwork, which stubbornly and ungracefully refused to work, raising an exception fatal for the tcf client. I've tracked the problem down to invocations of flush_stream, which has been withdrawn from the code base for a long time now. The last implementation seen in streams.c actually assigned an empty function to flush_stream, so it never actually did anything. Between versions 72ea7d0 (2011-Mar-23) and 7a8767c (2011-Aug-12) of lttng-agent, some of the errant calls to flush_stream have been deleted, but some still remain. They must also be deleted in order to get writeTraceNetwork to work. The two small diffs I propose follow: ############################## lttctlustlibustdcallbacks.c ############################## --- a/agent/lttctlustlibustdcallbacks.c 2011-08-12 11:02:15.000000000 -0400 +++ b/agent/lttctlustlibustdcallbacks.c 2011-09-22 16:51:06.000000000 -0400 @@ -85,7 +85,7 @@ write_stream(out, 0); write_stream(out, MARKER_EOM); - flush_stream(out); +// flush_stream(out); pthread_barrier_wait(tcf_data->barrier); } ############################## lttctlclient.c ############################## --- a/client/lttctlclient.c 2011-08-12 11:02:15.000000000 -0400 +++ b/client/lttctlclient.c 2011-09-22 17:10:40.000000000 -0400 @@ -480,9 +480,9 @@ write_stringz(&c->out, args[i]); } write_stream(&c->out, MARKER_EOM); - flush_stream(&c->out); +// flush_stream(&c->out); /* fprintf(stderr, "lttctlclient : Just sent a cmd!\n"); */ ############################## (end) ############################## Daniel U. Thibault R & D pour la d?fense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier) Syst?me de syst?mes (SdS) / System of Systems (SoS) Solutions informatiques et exp?rimentations (SIE) / Computing Solutions and Experimentations (CSE) 2459 Boul. Pie XI Nord Qu?bec, QC G3J 1X5 CANADA Vox : (418) 844-4000 x4245 Fax : (418) 844-4538 NAC: 918V QSDJ Gouvernement du Canada / Government of Canada > -------------- next part -------------- An HTML attachment was scrubbed... URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel.Thibault@drdc-rddc.gc.ca (Thibault, Daniel) Date: Fri, 23 Sep 2011 15:58:08 -0400 Subject: [ltt-dev] Getting writeTraceNetwork to work In-Reply-To: <3CA1A65C03C1A34C81BBC6272782E696719119@valcartierex01.valcartier.drdc-rddc.gc.ca> References: <3CA1A65C03C1A34C81BBC6272782E6967190AB@valcartierex01.valcartier.drdc-rddc.gc.ca> <3CA1A65C03C1A34C81BBC6272782E6967190B2@valcartierex01.valcartier.drdc-rddc.gc.ca> <3CA1A65C03C1A34C81BBC6272782E696719119@valcartierex01.valcartier.drdc-rddc.gc.ca> Message-ID: <3CA1A65C03C1A34C81BBC6272782E6967535AA@valcartierex01.valcartier.drdc-rddc.gc.ca> Message-ID: <20110923195808.C85oan-UZHCimmr6XCL6SlVp06ffEEJgqhkAxuUEZls@z> Back in May I asked about writeTraceNetwork, which stubbornly and ungracefully refused to work, raising an exception fatal for the tcf client. I've tracked the problem down to invocations of flush_stream, which has been withdrawn from the code base for a long time now. The last implementation seen in streams.c actually assigned an empty function to flush_stream, so it never actually did anything. Between versions 72ea7d0 (2011-Mar-23) and 7a8767c (2011-Aug-12) of lttng-agent, some of the errant calls to flush_stream have been deleted, but some still remain. They must also be deleted in order to get writeTraceNetwork to work. The two small diffs I propose follow: ############################## lttctlustlibustdcallbacks.c ############################## --- a/agent/lttctlustlibustdcallbacks.c 2011-08-12 11:02:15.000000000 -0400 +++ b/agent/lttctlustlibustdcallbacks.c 2011-09-22 16:51:06.000000000 -0400 @@ -85,7 +85,7 @@ write_stream(out, 0); write_stream(out, MARKER_EOM); - flush_stream(out); +// flush_stream(out); pthread_barrier_wait(tcf_data->barrier); } ############################## lttctlclient.c ############################## --- a/client/lttctlclient.c 2011-08-12 11:02:15.000000000 -0400 +++ b/client/lttctlclient.c 2011-09-22 17:10:40.000000000 -0400 @@ -480,9 +480,9 @@ write_stringz(&c->out, args[i]); } write_stream(&c->out, MARKER_EOM); - flush_stream(&c->out); +// flush_stream(&c->out); /* fprintf(stderr, "lttctlclient : Just sent a cmd!\n"); */ ############################## (end) ############################## Daniel U. Thibault R & D pour la d?fense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier) Syst?me de syst?mes (SdS) / System of Systems (SoS) Solutions informatiques et exp?rimentations (SIE) / Computing Solutions and Experimentations (CSE) 2459 Boul. Pie XI Nord Qu?bec, QC G3J 1X5 CANADA Vox : (418) 844-4000 x4245 Fax : (418) 844-4538 NAC: 918V QSDJ Gouvernement du Canada / Government of Canada > -------------- next part -------------- An HTML attachment was scrubbed... URL: