From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [lttng-dev] [PATCH lttng-tools] Fix: Define __STDC_LIMIT_MACROS to fix C++ builds
Date: Sat, 8 Feb 2014 15:43:48 +0000 (UTC) [thread overview]
Message-ID: <2121067902.21017.1391874228506.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <1391815941-30337-1-git-send-email-jeremie.galarneau@efficios.com>
----- Original Message -----
> From: "J?r?mie Galarneau" <jeremie.galarneau@efficios.com>
> To: lttng-dev at lists.lttng.org
> Sent: Friday, February 7, 2014 6:32:21 PM
> Subject: [lttng-dev] [PATCH lttng-tools] Fix: Define __STDC_LIMIT_MACROS to fix C++ builds
>
> Necessary to include the fixed-width type limits on glibc versions
> older than 2.18 when building with a C++ compiler.
>
> Signed-off-by: J?r?mie Galarneau <jeremie.galarneau at efficios.com>
> ---
> include/lttng/lttng.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/lttng/lttng.h b/include/lttng/lttng.h
> index 18dec2a..2d410fa 100644
> --- a/include/lttng/lttng.h
> +++ b/include/lttng/lttng.h
> @@ -23,7 +23,13 @@
> #define LTTNG_H
>
> #include <limits.h>
> +/*
> + * Necessary to include the fixed width type limits on glibc versions older
> + * than 2.18 when building with a C++ compiler.
> + */
> +#define __STDC_LIMIT_MACROS
> #include <stdint.h>
> +#undef __STDC_LIMIT_MACROS
This has a side-effect: it undefines the __STDC_LIMIT_MACROS if it was
defined prior to including this header. It should be:
#ifndef __STDC_LIMIT_MACROS
#define __STDC_LIMIT_MACROS
#include <stdint.h>
#undef __STDC_LIMIT_MACROS
#else /* #ifndef __STDC_LIMIT_MACROS */
#include <stdint.h>
#endif /* #else #ifndef __STDC_LIMIT_MACROS */
Thanks,
Mathieu
> #include <sys/types.h>
>
> /* Error codes that can be returned by API calls */
> --
> 1.8.5.2
>
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2014-02-08 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 23:32 Jérémie Galarneau
2014-02-08 15:43 ` Mathieu Desnoyers [this message]
2014-02-10 16:04 ` [lttng-dev] [PATCH lttng-tools v2] " Jérémie Galarneau
2014-02-10 17:55 ` Mathieu Desnoyers
2014-02-11 21:50 ` David Goulet
2014-02-10 16:05 ` [lttng-dev] [PATCH lttng-tools] " Jérémie Galarneau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2121067902.21017.1391874228506.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox