From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id D5NrDFg8zmpBNAIAWB0awg (envelope-from ) for ; Tue, 13 Oct 2026 10:12:40 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=lists.lttng.org header.i=@lists.lttng.org header.a=rsa-sha256 header.s=default header.b=ACsKcmjA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1049B1E04E; Tue, 13 Oct 2026 10:12:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from lists.lttng.org (lists.lttng.org [158.69.130.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C242A1E04E for ; Tue, 13 Oct 2026 10:12:38 -0400 (EDT) ARC-Filter: OpenARC Filter v1.2.1 lists.lttng.org 4j3x9r0cjjz1dMS ARC-Seal: i=1; d=lists.lttng.org; s=arc1; a=rsa-sha256; cv=none; t=1791900752; b=VuWbsriw62G5dgZQEq1F4EnzKL19qaHJMOYj2hhVFFAXh+4X5sQndYtZEA2qi8Hn/8NR 4bJCfTRT5cgQpaoMxuDZ+VlRIi2zcsFgnUDx2yf+Xa8mAZW0rMIqPUATdgCdh5o/9OF8C vaudZLkjCW9Mw7HA1KaCk38CiLQQT01/B+FeMf2yR/GEH9vJUpNjBmkPIJ1/k4TBE6A/L 9PAXLzToQ49pX9HFxJUw8X4cX+/cYE0xvuhbjWwB4lN9nqNqjsSmJczQoA1dBdvIRgN+n q4Hh8D8IRUQQ2P9tsvD4jjPmLWLtgzBRCXtOdYMN47TMEzimlHGrf6dQZL2gPJxyagg== ARC-Message-Signature: i=1; d=lists.lttng.org; s=arc1; a=rsa-sha256; c=relaxed/simple; t=1791900752; h=DKIM-Signature:To:Subject:Date:Message-ID:MIME-Version:From:From; bh=d4muYcg8ZUQHILcR4PNITQcugPxzVbnspnsK0kVbghY=; b=Mm1mPVk8ZCveZmCJ3ej0xnljkKXk4yVsoy/6Gmx0i5PplUQGbNfjhSnZyGXkhsM45QhZ gprDJ8SMyqMZrrFzakDp/UuiSNDcJjBDVDIyLgoVU6ZtCPlsYiBql4vMarO3w7+2zicId 2m7oIRujN0MVUq+TdxawL/uRhrPRaS8yu7+87dwW8tf3/6Xcv9+YcvUBD/G73s1cxsAGB AMhSr3pE5mlSPDOD0WzcY+QRDB5tsIaRkSaedK01+uKatDa0N6+mWGKwV6slE0hTUNs2W NbTBk0MmeXzBwOp+DGEQlW895/B/IWhWEc8WpjNtjKkm7IFug+sbtiDHYusXosmV9nA== ARC-Authentication-Results: i=1; lists.lttng.org; arc=none smtp.remote-ip="::1" DKIM-Filter: OpenDKIM Filter v2.11.0 lists.lttng.org 4j3x9r0cjjz1dMS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.lttng.org; s=default; t=1791900752; bh=nn7sg9h0/hAytSaIhs7HdLTHx5aQf1GPJfMMiCTeNXg=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=ACsKcmjAOFIGqiYBMaYPFWmD3koGpmCWxMgtAcmnG2Th1j5haAR8cRS08eV3YPghS aFNF6XX5LmNwHIVGGcV4pnlDmqHKt2h9AlVvKLF/dVTbFNen+SlViTDDHtnN03nYBy pOaRSe97eDE+MSTRggK2+QNZXfuQyb0C8lGn7GnAlUYOZltcvMdiVTVQb0EUckKEhd esfJ4Szw/nW4TPP164/ytUS9TRgifymr/auM4wTHsDny68Kl+ii2p61xQX3mM5mJFD g5+T9RkZypGvLFxCT2FyLttNujW5KjpJmd9FKxbY7otAEff0Kln3pynIjKD+XoRiHq eGGkk3Pnwn9tg== Received: from lists-lttng01.efficios.com (localhost [IPv6:::1]) by lists.lttng.org (Postfix) with ESMTP id 4j3x9r0cjjz1dMS; Tue, 13 Oct 2026 10:12:32 -0400 (EDT) ARC-Filter: OpenARC Filter v1.2.1 lists.lttng.org 4j3pzl1xwmz1Zsw DKIM-Filter: OpenDKIM Filter v2.11.0 lists.lttng.org 4j3pzl1xwmz1Zsw Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lists.lttng.org (Postfix) with ESMTPS id 4j3pzl1xwmz1Zsw for ; Tue, 13 Oct 2026 05:33:22 -0400 (EDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-c2e7496f947so432095366b.1 for ; Tue, 13 Oct 2026 02:33:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791884000; x=1792488800; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nn7sg9h0/hAytSaIhs7HdLTHx5aQf1GPJfMMiCTeNXg=; b=e/dyiZxUENrr6PhxrDJMLEky9TH9CpK6qs8L0/SSgJP5shAvsLvQtw+JaQQM4l/4du mvxgI9L1JR9jPboYPsYRlfk9gTS/ReTO1HItXo6tXOL8t0NXfHPIglmGEs6WzngJyIY6 FQ+geV9+E1lfc6B9A88hHCyZz3QwATFZJnvs/GZgELtiUN40YN+j3IJj0szp5rDlTJnH 9EvSlJmQwt28IyPLZ5zgrZHU+i6lrDhlvZ8yhDW9Ft+o2CDxkAnpAseFwBJfJ8Va2T5g 0aUqnmQk/qtHKeQDPAC/3iwvmOBjR1e27FPJIqqKPPaJsxS1EU8l6q/IYgDXGVELbLJv x/3w== X-Gm-Message-State: AFq9FYI3BcyTqTTC4g4gxruLlW40fSJcyT7OFhe6MFq7ahqsiRMaoMMQ s4swvJixW5qQei69xvxgajbNyYZ9Lp8fWQd9rcjALXC5/4F2BkH2XuC+LSdLAV9f3qE= X-Gm-Gg: AYBFou3wIafuj9cMvwpTmBPHnntync1wtzRPTycNLJfFSekuYdZ5E5y8F0EcSSXl5rq 2ivI0ok/BjjV7FX6h46sjmZzHw6SicV68sOzcGPjHNO/Hs5Nyr+ki75ue3tHnfLsd8dJW8JQ3Og cDcJSGsHOwoZ6rRcQgmOfFcv8rQzlVUrZ7R2fOliHSsuB2W+XI6Ng837xUU6xR/7xk/V1wrEQ6i T0VKLoaNs4pdzlkOZl6hgETjwJ1oybyyFwlodfTbFjrYl0Cn+COQzlMUSNBQRTXzhikS6fJVh1d iBqO7a/FA6F1bznSFvcXHlQOOgHCr5f+JZeYsRmjbg3MviXBVDCz2G7hRkWPcvdO1jwxQFn/p1S fbTCMgGkRgFV4VFaoZ17ubmaD1n3xeix9xYvzRK6FAxENPzJyGtw32uFLydocR/Gn38z8bZjuQX X/AAcE8rAqZrxyBp5uGX5KjrJp2YMkkZ3QZk30ujyXpafAsrU/VfdaQZE/jpi0f8O4Jerp9jMFa xSDceP+M+vGpW9P8Yu7VHHGqR8xqKAPKA== X-Received: by 2002:a17:907:9709:b0:c2e:1b4d:e9f4 with SMTP id a640c23a62f3a-c31a9f68e76mr1241513166b.31.1791883999658; Tue, 13 Oct 2026 02:33:19 -0700 (PDT) Received: from hp-z640.fritz.box ([109.78.82.167]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c31a9aa8511sm558244266b.59.2026.10.13.02.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2026 02:33:19 -0700 (PDT) X-Google-Original-From: OOHehir <40183643+OOHehir@users.noreply.github.com> To: lttng-dev@lists.lttng.org Cc: OOHehir Subject: [PATCH] Fix: tests: honour LTTNG_TOOLS_DISABLE_KERNEL_TESTS in two Python tests Date: Tue, 13 Oct 2026 10:33:18 +0100 Message-ID: <20261013093318.202203-1-40183643+OOHehir@users.noreply.github.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 13 Oct 2026 10:12:31 -0400 X-BeenThere: lttng-dev@lists.lttng.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: LTTng development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: OOHehir via lttng-dev Reply-To: OOHehir Errors-To: lttng-dev-bounces@lists.lttng.org Sender: "lttng-dev" From: OOHehir OBSERVED ISSUE ━━━━━━━━━━━━━━ On a target without lttng-modules, kernel/test_event_disable.py & the kernel cases of tools/save-load/test_save_load.py fail with "Kernel tracer not available", although the test run sets LTTNG_TOOLS_DISABLE_KERNEL_TESTS=1. Observed with the Yocto Project ptest on riscv64, which ships no lttng-modules. CAUSE ━━━━━ Both scripts only check that they run as root before running kernel cases, while the other Python tests use lttngtest._Environment.run_kernel_tests(), which also honours LTTNG_TOOLS_DISABLE_KERNEL_TESTS. SOLUTION ━━━━━━━━ Use run_kernel_tests() in both scripts. It checks for root as before, & also honours LTTNG_TOOLS_DISABLE_KERNEL_TESTS. Signed-off-by: OOHehir --- tests/regression/kernel/test_event_disable.py | 7 ++----- tests/regression/tools/save-load/test_save_load.py | 9 ++++----- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/tests/regression/kernel/test_event_disable.py b/tests/regression/kernel/test_event_disable.py index da9f146..a373544 100755 --- a/tests/regression/kernel/test_event_disable.py +++ b/tests/regression/kernel/test_event_disable.py @@ -15,7 +15,6 @@ Validates that disabling events works correctly: - Disabling by name disables all matching rules regardless of filters """ -import os import pathlib import sys import traceback @@ -307,11 +306,9 @@ if __name__ == "__main__": ), ] - is_root = os.getuid() == 0 - - if not is_root: + if not lttngtest._Environment.run_kernel_tests(): tap = lttngtest.TapGenerator(len(kernel_tests)) - tap.skip_all_remaining("Kernel tests require root privileges") + tap.skip_all_remaining("Kernel tests not enabled") sys.exit(0) tap = lttngtest.TapGenerator(len(kernel_tests)) diff --git a/tests/regression/tools/save-load/test_save_load.py b/tests/regression/tools/save-load/test_save_load.py index 9dd8042..1983263 100755 --- a/tests/regression/tools/save-load/test_save_load.py +++ b/tests/regression/tools/save-load/test_save_load.py @@ -13,7 +13,6 @@ through save/load cycles, including: - Kernel syscalls and tracepoints """ -import os import pathlib import sys import traceback @@ -953,11 +952,11 @@ if __name__ == "__main__": ), ] - is_root = os.getuid() == 0 + run_kernel_tests = lttngtest._Environment.run_kernel_tests() allows_destructive = lttngtest._Environment.allows_destructive() total_tests = len(user_tests) + len(agent_tests) - if is_root: + if run_kernel_tests: total_tests += len(kernel_tests) if allows_destructive: total_tests += len(destructive_kernel_tests) @@ -971,7 +970,7 @@ if __name__ == "__main__": for test_name, test_func, kwargs in agent_tests: run_test(tap, test_env, test_func, test_name, **kwargs) - if is_root: + if run_kernel_tests: with lttngtest.test_environment( with_sessiond=True, log=tap.diagnostic, enable_kernel_domain=True ) as test_env: @@ -986,6 +985,6 @@ if __name__ == "__main__": "Skipping destructive kernel tests (LTTNG_ENABLE_DESTRUCTIVE_TESTS not set)" ) else: - tap.diagnostic("Skipping kernel tests (not running as root)") + tap.diagnostic("Skipping kernel tests (not enabled)") sys.exit(0 if tap.is_successful else 1) -- 2.43.0