From: mjeanson@efficios.com (Michael Jeanson)
Subject: [lttng-dev] [PATCH lttng-modules 4/5] fix: mm: move recent_rotated pages calculation to shrink_inactive_list() (v5.2)
Date: Tue, 21 May 2019 16:33:13 -0400 [thread overview]
Message-ID: <20190521203314.8577-4-mjeanson@efficios.com> (raw)
In-Reply-To: <20190521203314.8577-1-mjeanson@efficios.com>
See upstream commit:
commit 886cf1901db962cee5f8b82b9b260079a5e8a4eb
Author: Kirill Tkhai <ktkhai at virtuozzo.com>
Date: Mon May 13 17:16:51 2019 -0700
mm: move recent_rotated pages calculation to shrink_inactive_list()
Patch series "mm: Generalize putback functions"]
putback_inactive_pages() and move_active_pages_to_lru() are almost
similar, so this patchset merges them ina single function.
This patch (of 4):
The patch moves the calculation from putback_inactive_pages() to
shrink_inactive_list(). This makes putback_inactive_pages() looking more
similar to move_active_pages_to_lru().
To do that, we account activated pages in reclaim_stat::nr_activate.
Since a page may change its LRU type from anon to file cache inside
shrink_page_list() (see ClearPageSwapBacked()), we have to account pages
for the both types. So, nr_activate becomes an array.
Previously we used nr_activate to account PGACTIVATE events, but now we
account them into pgactivate variable (since they are about number of
pages in general, not about sum of hpage_nr_pages).
Signed-off-by: Michael Jeanson <mjeanson at efficios.com>
---
instrumentation/events/lttng-module/mm_vmscan.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/instrumentation/events/lttng-module/mm_vmscan.h b/instrumentation/events/lttng-module/mm_vmscan.h
index 417472c..3f9ffde 100644
--- a/instrumentation/events/lttng-module/mm_vmscan.h
+++ b/instrumentation/events/lttng-module/mm_vmscan.h
@@ -625,7 +625,8 @@ LTTNG_TRACEPOINT_EVENT(mm_vmscan_lru_shrink_inactive,
ctf_integer(unsigned long, nr_writeback, stat->nr_writeback)
ctf_integer(unsigned long, nr_congested, stat->nr_congested)
ctf_integer(unsigned long, nr_immediate, stat->nr_immediate)
- ctf_integer(unsigned long, nr_activate, stat->nr_activate)
+ ctf_integer(unsigned long, nr_activate0, stat->nr_activate[0])
+ ctf_integer(unsigned long, nr_activate1, stat->nr_activate[1])
ctf_integer(unsigned long, nr_ref_keep, stat->nr_ref_keep)
ctf_integer(unsigned long, nr_unmap_fail, stat->nr_unmap_fail)
ctf_integer(int, priority, priority)
--
2.17.1
next prev parent reply other threads:[~2019-05-21 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 20:33 [lttng-dev] [PATCH lttng-modules 1/5] fix: timer/trace: Improve timer tracing (v5.2) Michael Jeanson
2019-05-21 20:33 ` [lttng-dev] [PATCH lttng-modules 2/5] fix: mm/vmscan: drop may_writepage and classzone_idx from direct reclaim begin template (v5.2) Michael Jeanson
2019-05-21 20:33 ` [lttng-dev] [PATCH lttng-modules 3/5] fix: mm/vmscan: simplify trace_reclaim_flags and trace_shrink_flags (v5.2) Michael Jeanson
2019-05-21 20:33 ` Michael Jeanson [this message]
2019-05-21 20:53 ` [lttng-dev] [PATCH lttng-modules 4/5] fix: mm: move recent_rotated pages calculation to shrink_inactive_list() (v5.2) Mathieu Desnoyers
2019-05-21 21:16 ` Steven Rostedt
2019-05-22 8:37 ` Kirill Tkhai
2019-05-21 20:33 ` [lttng-dev] [PATCH lttng-modules 5/5] fix: random: only read from /dev/random after its pool has received 128 bits (v5.2) Michael Jeanson
2019-05-22 15:37 ` [lttng-dev] [PATCH lttng-modules 1/5] fix: timer/trace: Improve timer tracing (v5.2) Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521203314.8577-4-mjeanson@efficios.com \
--to=mjeanson@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox