Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: dgoulet@efficios.com (David Goulet)
Subject: [lttng-dev] [PATCH] Use uint32_t for lttng_viewer_stream.metadata_flag
Date: Tue, 4 Feb 2014 14:39:30 -0500	[thread overview]
Message-ID: <20140204193930.GK13440@thessa> (raw)
In-Reply-To: <1390002463-21184-1-git-send-email-marc-andre.laperle@ericsson.com>

FYI, there is a lot of development on the relayd right now so I'll be
merging this patch with everything else thus consider it merged but not
yet upstream.

Once upstream in the master branch, it will be ported to 2.4 stable.

Big thanks!
David

On 17 Jan (18:47:43), Marc-Andre Laperle wrote:
> This struct is meant to be sent over the network so members should be
> of exact-width.
> 
> Signed-off-by: Marc-Andre Laperle <marc-andre.laperle at ericsson.com>
> ---
>  src/bin/lttng-relayd/lttng-viewer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/lttng-relayd/lttng-viewer.h b/src/bin/lttng-relayd/lttng-viewer.h
> index 1977a43..6330270 100644
> --- a/src/bin/lttng-relayd/lttng-viewer.h
> +++ b/src/bin/lttng-relayd/lttng-viewer.h
> @@ -100,7 +100,7 @@ struct lttng_viewer_session {
>  struct lttng_viewer_stream {
>  	uint64_t id;
>  	uint64_t ctf_trace_id;
> -	int metadata_flag;
> +	uint32_t metadata_flag;
>  	char path_name[LTTNG_VIEWER_PATH_MAX];
>  	char channel_name[LTTNG_VIEWER_NAME_MAX];
>  } __attribute__((__packed__));
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: Digital signature
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20140204/612df5df/attachment.pgp>


           reply	other threads:[~2014-02-04 19:39 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1390002463-21184-1-git-send-email-marc-andre.laperle@ericsson.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140204193930.GK13440@thessa \
    --to=dgoulet@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox