From: dgoulet@efficios.com (David Goulet)
Subject: [lttng-dev] [lttng-tools PATCH 0/5] utils_expand_path fix
Date: Mon, 25 Nov 2013 10:51:06 -0500 [thread overview]
Message-ID: <20131125155106.GB8371@thessa> (raw)
In-Reply-To: <1385245948-23011-1-git-send-email-raphael.beamonte@gmail.com>
Fixes every use case I had that failed previously :).
Merged. Thanks!
David
On 23 Nov (17:32:23), Rapha?l Beamonte wrote:
> Hello David!
>
> Here is the fix needed to have the expected behavior for path that
> ends with '/.' or '/..'. I also profit to send patches for the unit
> test to allow to add tests using an existing tree and symlinks,
> adding the missing copyright in utils.c and correcting the indentation
> of one comment.
>
> Waiting for your comments!
>
> Thanks,
> Rapha?l
>
>
> Rapha?l Beamonte (5):
> Add missing copyright to utils.c
> Fix: comment indentation
> Fix: utils_expand_path now works for paths that ends with '/.' or
> '/..'
> Tests: add symlink tests for test_utils_expand_path
> Tests: add valid test cases to test_utils_expand_path
>
> src/common/utils.c | 30 +++++-
> tests/unit/test_utils_expand_path.c | 175 ++++++++++++++++++++++++++++++++++-
> 2 files changed, 199 insertions(+), 6 deletions(-)
>
> --
> 1.7.10.4
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: Digital signature
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20131125/f9e88635/attachment-0001.pgp>
next prev parent reply other threads:[~2013-11-25 15:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 4:32 [lttng-dev] [lttng-tools PATCH 0/2] utils_expand_path as realpath(3) for non-existing directories Raphaël Beamonte
2013-11-08 4:32 ` [lttng-dev] [lttng-tools PATCH 1/2] Introduce a new utils_resolve_relative function Raphaël Beamonte
2013-11-12 19:51 ` David Goulet
2013-11-13 5:34 ` [lttng-dev] [lttng-tools PATCH 0/4] Update to utils_expand_path as realpath(3) for non-existing directories Raphaël Beamonte
2013-11-13 5:34 ` [lttng-dev] [lttng-tools PATCH 1/4] Introduce a new utils_resolve_relative function Raphaël Beamonte
2013-11-14 14:19 ` Mathieu Desnoyers
2013-11-14 17:07 ` Raphaël Beamonte
2013-11-13 5:34 ` [lttng-dev] [lttng-tools PATCH 2/4] Tests: Add test_utils_resolve_relative to unit tests Raphaël Beamonte
2013-11-13 5:34 ` [lttng-dev] [lttng-tools PATCH 3/4] Correct the behavior of the utils_expand_path function Raphaël Beamonte
2013-11-14 2:44 ` Mathieu Desnoyers
2013-11-14 3:27 ` Raphaël Beamonte
2013-11-14 13:46 ` Mathieu Desnoyers
2013-11-14 14:10 ` Mathieu Desnoyers
2013-11-14 16:00 ` Raphaël Beamonte
2013-11-14 16:14 ` Mathieu Desnoyers
2013-11-15 0:58 ` [lttng-dev] [lttng-tools PATCH 0/5] Follow up to the realpath(3) for unexistent paths Raphaël Beamonte
2013-11-15 0:58 ` [lttng-dev] [lttng-tools PATCH 1/5] Tests: add a check in test_utils_expand_path to avoid segfault if result is NULL Raphaël Beamonte
2013-11-15 0:58 ` [lttng-dev] [lttng-tools PATCH 2/5] Tests: move invalid tests in test_utils_expand_path that should be valid Raphaël Beamonte
2013-11-15 0:58 ` [lttng-dev] [lttng-tools PATCH 3/5] Introduce a new utils_partial_realpath function Raphaël Beamonte
2013-11-15 0:58 ` [lttng-dev] [lttng-tools PATCH 4/5] Change the utils_expand_path function to use utils_partial_realpath Raphaël Beamonte
2013-11-15 0:58 ` [lttng-dev] [lttng-tools PATCH 5/5] Remove the utils_resolve_relative function that is not useful anymore Raphaël Beamonte
2013-11-15 15:45 ` [lttng-dev] [lttng-tools PATCH 0/5] Follow up to the realpath(3) for unexistent paths David Goulet
2013-11-23 22:32 ` [lttng-dev] [lttng-tools PATCH 0/5] utils_expand_path fix Raphaël Beamonte
2013-11-23 22:32 ` [lttng-dev] [lttng-tools PATCH 1/5] Add missing copyright to utils.c Raphaël Beamonte
2013-11-23 22:32 ` [lttng-dev] [lttng-tools PATCH 2/5] Fix: comment indentation Raphaël Beamonte
2013-11-23 22:32 ` [lttng-dev] [lttng-tools PATCH 3/5] Fix: utils_expand_path now works for paths that ends with '/.' or '/..' Raphaël Beamonte
2013-11-23 22:32 ` [lttng-dev] [lttng-tools PATCH 4/5] Tests: add symlink tests for test_utils_expand_path Raphaël Beamonte
2013-11-23 22:32 ` [lttng-dev] [lttng-tools PATCH 5/5] Tests: add valid test cases to test_utils_expand_path Raphaël Beamonte
2013-11-25 15:51 ` David Goulet [this message]
2013-11-13 5:34 ` [lttng-dev] [lttng-tools PATCH 4/4] Tests: Add test_utils_expand_path to unit tests Raphaël Beamonte
2013-11-13 21:28 ` [lttng-dev] [lttng-tools PATCH 0/4] Update to utils_expand_path as realpath(3) for non-existing directories David Goulet
2013-11-08 4:32 ` [lttng-dev] [lttng-tools PATCH 2/2] Correct the behavior of the utils_expand_path function Raphaël Beamonte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125155106.GB8371@thessa \
--to=dgoulet@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox