Mirror of the lttng-dev mailing list
 help / color / mirror / Atom feed
From: compudj@krystal.dyndns.org (Mathieu Desnoyers)
Subject: [lttng-dev] [lttng-tools PATCH 1/2] Cleanup configure.ac
Date: Tue, 29 Nov 2011 19:17:27 -0500	[thread overview]
Message-ID: <20111130001727.GA15401@Krystal> (raw)
In-Reply-To: <1322611444-19408-1-git-send-email-alexandre.montplaisir@gmail.com>

* Alexandre Montplaisir (alexandre.montplaisir at gmail.com) wrote:
> Use AS_IF() and AS_ECHO() macros whenever possible.
> Print the configuration options at the end of the script
> (so they don't get lost in the sea of the configure output).

Merged, thanks!

Mathieu

> 
> Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir at gmail.com>
> ---
>  configure.ac |   23 +++++++++++++----------
>  1 files changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b73cf0f..01e15d3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -85,21 +85,14 @@ AC_CHECK_DECL([caa_likely], [],
>  
>  # Check liblttng-ust-ctl library
>  AC_ARG_ENABLE(lttng-ust,
> -	[  --disable-lttng-ust     build without LTTng-UST (Userspace Tracing) support.],
> +	AS_HELP_STRING([--disable-lttng-ust],[build without LTTng-UST (Userspace Tracing) support]),
>  	lttng_ust_support=$enableval, lttng_ust_support=yes)
>  
> -[
> -if test "x$lttng_ust_support" = "xno"; then
> -	echo "LTTng-UST support disabled."
> -else
> -]
> +AS_IF([test "x$lttng_ust_support" = "xyes"], [
>  	AC_CHECK_LIB([lttng-ust-ctl], [ustctl_create_session], [],
>  		[AC_MSG_ERROR([Cannot find LTTng-UST. Use [LDFLAGS]=-Ldir to specify its location, or specify --disable-lttng-ust to build lttng-tools without LTTng-UST support.])]
>  	)
> -[
> -	echo "LTTng-UST support enabled."
> -fi
> -]
> +])
>  
>  AM_CONDITIONAL([HAVE_LIBLTTNG_UST_CTL], [ test "x$ac_cv_lib_lttng_ust_ctl_ustctl_create_session" = "xyes" ])
>  
> @@ -146,3 +139,13 @@ AC_CONFIG_FILES([
>  ])
>  
>  AC_OUTPUT
> +
> +# Mini-report on what will be built
> +AS_ECHO("")
> +
> +AS_ECHO_N("Lttng-UST support: ")
> +AS_IF([test "x$lttng_ust_support" = "xyes"], [AS_ECHO("Enabled")],
> +	[AS_ECHO("Disabled")])
> +
> +AS_ECHO("")
> +
> -- 
> 1.7.7.3
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com



      parent reply	other threads:[~2011-11-30  0:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  0:04 Alexandre Montplaisir
2011-11-30  0:04 ` [lttng-dev] [lttng-tools PATCH 2/2] Add a --with-consumerd-only configure option Alexandre Montplaisir
2011-11-30  0:18   ` Mathieu Desnoyers
2011-11-30  0:17 ` Mathieu Desnoyers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111130001727.GA15401@Krystal \
    --to=compudj@krystal.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox