From: greg@kroah.com (Greg KH)
Subject: [lttng-dev] LTTng driver submission for inclusion in staging (resend)
Date: Sat, 26 Nov 2011 18:28:25 -0800 [thread overview]
Message-ID: <20111127022825.GA12349@kroah.com> (raw)
In-Reply-To: <1322319824-6529-1-git-send-email-mathieu.desnoyers@efficios.com>
On Sat, Nov 26, 2011 at 10:03:25AM -0500, Mathieu Desnoyers wrote:
>
> Hi,
>
> I hereby propose the LTTng kernel tracer for inclusion into the staging
> area of the Linux kernel. For those eager to try it out, and to get
> information about the features of this tracer, you should grab the
> control/consumer/viewer tools at: http://lttng.org/lttng2.0
>
> Feedback is very welcome!
I applied this, but it failed to build:
CC [M] drivers/staging/lttng/ltt-ring-buffer-client-discard.o
In file included from drivers/staging/lttng/ltt-tracer.h:24:0,
from drivers/staging/lttng/ltt-ring-buffer-client-discard.c:12:
drivers/staging/lttng/wrapper/trace-clock.h: In function ?get_trace_clock?:
drivers/staging/lttng/wrapper/trace-clock.h:66:2: warning: #warning "LTTng: Using mainline kernel monotonic clock. NMIs will not be traced, and expect significant performance degradation compared to the LTTng trace clocks. Integration of the LTTng 0.x trace clocks into LTTng 2.0 is planned in a near future." [-Wcpp]
In file included from drivers/staging/lttng/wrapper/ringbuffer/frontend_types.h:1:0,
from drivers/staging/lttng/ltt-ring-buffer-client.h:18,
from drivers/staging/lttng/ltt-ring-buffer-client-discard.c:17:
drivers/staging/lttng/wrapper/ringbuffer/../../lib/ringbuffer/frontend_types.h: At top level:
drivers/staging/lttng/wrapper/ringbuffer/../../lib/ringbuffer/frontend_types.h:23:86: fatal error: ../../lib/prio_heap/lttng_prio_heap.h: No such file or directory
compilation terminated.
The build warning is a bit harsh, and should be a Kconfig option or a run-time
kernel log message, please fix that. No new code should ever add build
warnings, especially ones like this.
The build error isn't ok, so I can't apply this series, sorry :(
Care to fix this up and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2011-11-27 2:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 15:03 Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 01/19] lttng lib: ring buffer Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 02/19] lttng lib: portable bitfield read/write header Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 03/19] lttng: BUILD_RUNTIME_BUG_ON Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 04/19] lttng: offset alignment header Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 05/19] lttng libs: add Makefile Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 06/19] lttng wrappers Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 07/19] lttng instrumentation: tracepoint events Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 08/19] lttng: syscall instrumentation Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 09/19] lttng: lib ring buffer clients Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 10/19] lttng: tracer control and core structures Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 11/19] lttng: dynamically selectable context information Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 12/19] lttng: timing calibration feature Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 13/19] lttng: debugfs and procfs ABI Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 14/19] lttng: Add documentation and license files Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 15/19] lttng: add system call instrumentation probe Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 16/19] lttng: probe callbacks Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 17/19] lttng: toplevel Makefile and Kconfig Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 18/19] staging: add LTTng to build Mathieu Desnoyers
2011-11-26 15:03 ` [lttng-dev] [PATCH 19/19] Add LTTng entry to MAINTAINERS file Mathieu Desnoyers
2011-11-27 2:24 ` [lttng-dev] [PATCH 14/19] lttng: Add documentation and license files Greg KH
2011-11-27 10:04 ` Mathieu Desnoyers
2011-11-27 2:28 ` Greg KH [this message]
2011-11-27 10:07 ` [lttng-dev] LTTng driver submission for inclusion in staging (resend) Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111127022825.GA12349@kroah.com \
--to=greg@kroah.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox