From mboxrd@z Thu Jan 1 00:00:00 1970 From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers) Date: Tue, 15 Nov 2011 06:20:02 -0500 Subject: [ltt-dev] [PATCH 5/9] use random value for hash value directly In-Reply-To: <1321246259-21223-6-git-send-email-laijs@cn.fujitsu.com> References: <1321246259-21223-1-git-send-email-laijs@cn.fujitsu.com> <1321246259-21223-6-git-send-email-laijs@cn.fujitsu.com> Message-ID: <20111115112002.GD16701@Krystal> * Lai Jiangshan (laijs at cn.fujitsu.com) wrote: [...] > struct lfht_test_node { > struct cds_lfht_node node; > - void *key; > - unsigned int key_len; > + unsigned long hash; > /* cache-cold for iteration */ > struct rcu_head head; I'm really unsure about this. One of the test-case should be to walk through identical-hash-value-chain and find the right node by matching its key. If we make the hash equal to the key, we don't test the "match" code anymore. Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com