From: mathieu.desnoyers@efficios.com (Mathieu Desnoyers)
Subject: [ltt-dev] [PATCH 03/10] use get_cpu_call_rcu_data() for get_call_rcu_data()
Date: Thu, 15 Sep 2011 11:08:50 -0400 [thread overview]
Message-ID: <20110915150850.GD3813@Krystal> (raw)
In-Reply-To: <2e8c002c93f9f0105fef603f48c13aa8c2b6d807.1316064655.git.laijs@cn.fujitsu.com>
* Lai Jiangshan (laijs at cn.fujitsu.com) wrote:
> Signed-off-by: Lai Jiangshan <laijs at cn.fujitsu.com>
[ Impact: refactor duplicated code ]
Merged, thanks!
Mathieu
> ---
> urcu-call-rcu-impl.h | 19 +++++++------------
> 1 files changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/urcu-call-rcu-impl.h b/urcu-call-rcu-impl.h
> index e0a8fd8..1fbce98 100644
> --- a/urcu-call-rcu-impl.h
> +++ b/urcu-call-rcu-impl.h
> @@ -435,22 +435,17 @@ struct call_rcu_data *get_default_call_rcu_data(void)
> */
> struct call_rcu_data *get_call_rcu_data(void)
> {
> - int curcpu;
> - static int warned = 0;
> + struct call_rcu_data *crd;
>
> if (thread_call_rcu_data != NULL)
> return thread_call_rcu_data;
> - if (maxcpus <= 0)
> - return get_default_call_rcu_data();
> - curcpu = sched_getcpu();
> - if (!warned && (curcpu < 0 || maxcpus <= curcpu)) {
> - fprintf(stderr, "[error] liburcu: gcrd CPU # out of range\n");
> - warned = 1;
> +
> + if (maxcpus > 0) {
> + crd = get_cpu_call_rcu_data(sched_getcpu());
> + if (crd)
> + return crd;
> }
> - if (curcpu >= 0 && maxcpus > curcpu &&
> - per_cpu_call_rcu_data != NULL &&
> - per_cpu_call_rcu_data[curcpu] != NULL)
> - return per_cpu_call_rcu_data[curcpu];
> +
> return get_default_call_rcu_data();
> }
>
> --
> 1.7.4.4
>
--
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2011-09-15 15:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 5:38 [ltt-dev] [PATCH 00/10] urcu,call_rcu: minior fixes, round1 Lai Jiangshan
2011-09-15 5:38 ` [ltt-dev] [PATCH 01/10] add missing static Lai Jiangshan
2011-09-15 14:54 ` Mathieu Desnoyers
2011-09-15 5:38 ` [ltt-dev] [PATCH 02/10] init maxcpus before use it Lai Jiangshan
2011-09-15 14:59 ` Mathieu Desnoyers
2011-09-15 5:38 ` [ltt-dev] [PATCH 03/10] use get_cpu_call_rcu_data() for get_call_rcu_data() Lai Jiangshan
2011-09-15 15:08 ` Mathieu Desnoyers [this message]
2011-09-15 5:38 ` [ltt-dev] [PATCH 04/10] use cds_list_for_each_entry_safe() Lai Jiangshan
2011-09-15 15:11 ` Mathieu Desnoyers
2011-09-15 5:39 ` [ltt-dev] [PATCH 05/10] avoid memory leak in call_rcu_data_free() Lai Jiangshan
2011-09-15 15:14 ` Mathieu Desnoyers
2011-09-15 5:39 ` [ltt-dev] [PATCH 06/10] wake up default call_rcu thread after we move the leftover callbacks Lai Jiangshan
2011-09-15 15:16 ` Mathieu Desnoyers
2011-09-15 5:39 ` [ltt-dev] [PATCH 07/10] protect writing to per_cpu_call_rcu_data[*] Lai Jiangshan
2011-09-15 15:17 ` Mathieu Desnoyers
2011-09-15 5:39 ` [ltt-dev] [PATCH 08/10] Return -EEXIST when the old cpu call_rcu_data has not been removed Lai Jiangshan
2011-09-15 15:19 ` Mathieu Desnoyers
2011-09-15 5:39 ` [ltt-dev] [PATCH 09/10] avoid leaking crdp for failed path Lai Jiangshan
2011-09-15 15:21 ` Mathieu Desnoyers
2011-09-15 15:23 ` [ltt-dev] [PATCH 00/10] urcu,call_rcu: minior fixes, round1 Mathieu Desnoyers
2011-09-15 15:57 ` Paul E. McKenney
2011-09-16 3:33 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915150850.GD3813@Krystal \
--to=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox